Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lite version with fewer dependency #236

Closed
yujunz opened this issue Mar 4, 2020 · 4 comments
Closed

Lite version with fewer dependency #236

yujunz opened this issue Mar 4, 2020 · 4 comments

Comments

@yujunz
Copy link

yujunz commented Mar 4, 2020

We plan to integrate go-getter in kubernetes-sigs/kustomize#2169 since go-getter has everything we need in getting remote sources.

However, kustomize itself is integrated in kubectl which has dependency conflict with some modules used by go-getter.

I wonder if we can have a lite version of go-getter with fewer dependency, mainly stripping s3, gcs and cmd to reduce the transitive dependencies. (See yujunz@fc7e8cd). This will make go-getter easier to integrate in other tools as a library.

What do you think about it?

cc @monopole @Liujingfang1

@azr
Copy link
Contributor

azr commented Mar 5, 2020

Hello there, thanks for opening; we currently started a v2 branch with some breaking changes, it is not tagged yet and if you want to: one option we were considering would be to split the getters into sub modules, the cmd pkg can also be into a different submodule. Would you like to start working on this ? I still have to learn/grasp on how everything works with modules, but we can gain some time in there 🙂.

For the v2, we carved out a new Request struct from the Client struct; the v2 can also tell where the file was put.

@yujunz
Copy link
Author

yujunz commented Mar 5, 2020

That sounds interesting. Yes, I can contribute some time to splitting go-getter into sub modules.

Could you elaborate a bit the goals and no goals v2 so that I can understand the context better. And if there is already some work going on. Where can I find more details and follow the progress? Thanks.

@azr
Copy link
Contributor

azr commented Mar 5, 2020

Everything is in the v2 https://github.com/hashicorp/go-getter/tree/v2 branch and the request/client splitting is already in there. The Packer project which I help maintain needed some features which were breaking changes so I made them. PRs are here: #230 #231 #232

I am also considering this other breaking change that some users requested already in #207 and #193

@azr azr added the duplicate label Mar 5, 2020
@azr
Copy link
Contributor

azr commented Mar 5, 2020

Actually I think it would be better to move the conversation to #193, closing this one. I'll recap there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants