-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lite version with fewer dependency #236
Comments
Hello there, thanks for opening; we currently started a For the |
That sounds interesting. Yes, I can contribute some time to splitting go-getter into sub modules. Could you elaborate a bit the goals and no goals |
Everything is in the v2 https://github.com/hashicorp/go-getter/tree/v2 branch and the request/client splitting is already in there. The Packer project which I help maintain needed some features which were breaking changes so I made them. PRs are here: #230 #231 #232 I am also considering this other breaking change that some users requested already in #207 and #193 |
Actually I think it would be better to move the conversation to #193, closing this one. I'll recap there. |
We plan to integrate go-getter in kubernetes-sigs/kustomize#2169 since go-getter has everything we need in getting remote sources.
However, kustomize itself is integrated in kubectl which has dependency conflict with some modules used by go-getter.
I wonder if we can have a lite version of go-getter with fewer dependency, mainly stripping s3, gcs and cmd to reduce the transitive dependencies. (See yujunz@fc7e8cd). This will make go-getter easier to integrate in other tools as a library.
What do you think about it?
cc @monopole @Liujingfang1
The text was updated successfully, but these errors were encountered: