Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixed taskfile example not working with cluster setup partially installed #978

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

chore: fixed taskfile example not working with cluster setup partially installed #978

wants to merge 18 commits into from
+1,096 −240

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • fixed taskfile example not working with cluster setup partially installed

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

Unit Test Results - Linux

  1 files  ±0   57 suites  ±0   3s ⏱️ -1s
220 tests ±0  218 ✅  - 2  0 💤 ±0  2 ❌ +2 
230 runs  ±0  228 ✅  - 2  0 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 2335828. ± Comparison against base commit a5fab1e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

Unit Test Results - Windows

  1 files  ±0   57 suites  ±0   13s ⏱️ -1s
220 tests ±0  218 ✅  - 2  0 💤 ±0  2 ❌ +2 
230 runs  ±0  228 ✅  - 2  0 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 2335828. ± Comparison against base commit a5fab1e.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon changed the title 00966 cluster setup issue chore: fixed taskfile example not working with cluster setup partially installed Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

E2E Test Report

 13 files  ±0  105 suites  ±0   59m 56s ⏱️ + 2m 28s
220 tests ±0  220 ✅ ±0  0 💤 ±0  0 ❌ ±0 
223 runs  ±0  223 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a69f531. ± Comparison against base commit 88c2506.

This pull request removes 97 and adds 97 tests. Note that renamed tests count towards both. 
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.56.5] Node should have started successfully [mode kill, release v0.56.5] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.56.5] Node should refresh successfully [mode kill, release v0.56.5] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.56.5] Node should have started successfully [mode stop, release v0.56.5] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.56.5] Node should refresh successfully [mode stop, release v0.56.5] Account creation should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.56.5] Node should have started successfully [mode kill, release v0.56.5] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.56.5] Node should refresh successfully [mode kill, release v0.56.5] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.56.5] Node should have started successfully [mode stop, release v0.56.5] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.56.5] Node should refresh successfully [mode stop, release v0.56.5] Balance query should succeed
Node Proxy should be UP [mode kill, release v0.56.5 ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.56.5] Node should have started successfully [mode kill, release v0.56.5] Node Proxy should be UP [mode kill, release v0.56.5
Node Proxy should be UP [mode stop, release v0.56.5 ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.56.5] Node should have started successfully [mode stop, release v0.56.5] Node Proxy should be UP [mode stop, release v0.56.5
…

Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.57.1] Node should have started successfully [mode kill, release v0.57.1] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.57.1] Node should refresh successfully [mode kill, release v0.57.1] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.57.1] Node should have started successfully [mode stop, release v0.57.1] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.57.1] Node should refresh successfully [mode stop, release v0.57.1] Account creation should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.57.1] Node should have started successfully [mode kill, release v0.57.1] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.57.1] Node should refresh successfully [mode kill, release v0.57.1] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.57.1] Node should have started successfully [mode stop, release v0.57.1] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.57.1] Node should refresh successfully [mode stop, release v0.57.1] Balance query should succeed
Node Proxy should be UP [mode kill, release v0.57.1 ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.57.1] Node should have started successfully [mode kill, release v0.57.1] Node Proxy should be UP [mode kill, release v0.57.1
Node Proxy should be UP [mode stop, release v0.57.1 ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.57.1] Node should have started successfully [mode stop, release v0.57.1] Node Proxy should be UP [mode stop, release v0.57.1
…

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

E2E Test Report

 16 files  121 suites   1h 18m 33s ⏱️
256 tests 256 ✅ 0 💤 0 ❌
259 runs  259 ✅ 0 💤 0 ❌

Results for commit 00d5be1.

♻️ This comment has been updated with latest results.

@codacy-production Codacy Production
Copy link

codacy-production bot commented Dec 11, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 06e60261 ✅ ∅
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (06e6026) Report Missing Report Missing Report Missing
Head commit (00d5be1) 19225 16537 86.02%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#978) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.00%. Comparing base (79410f0) to head (00d5be1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   85.01%   85.00%   -0.01%     
==========================================
  Files          71       71              
  Lines       19221    19225       +4     
  Branches     1219     1276      +57     
==========================================
+ Hits        16340    16342       +2     
+ Misses       2876     2864      -12     
- Partials        5       19      +14

see 6 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon mentioned this pull request Dec 12, 2024
Merged
@jeromy-cannon jeromy-cannon force-pushed the 00966-cluster-setup-issue branch 2 times, most recently from f0e15bd to 00d5be1 Compare December 13, 2024 15:26
@jeromy-cannon
squashed commits
6fa31f9 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon
updated sleep duration after writing support zip in get node logs fun…
4c6e3a9 
…ction

Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon
fixed incorrect log messages
56d7d4e 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon
added quiet to all flags list
20616c7 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon
added missing quiet mode flags
e7f6103 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon
wrapped uncaught exception
51b5365 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon
bumped version and other changes
b355efd 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon
add releasing lease message
8496721 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon
update TODOs
f37f0b4 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon
updated error messages
a1caf68 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon
better error message
531b922 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon
removed duplicated deploy task
1f78b18 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon jeromy-cannon force-pushed the 00966-cluster-setup-issue branch from d55da6e to 1f78b18 Compare December 16, 2024 13:26
@jeromy-cannon
npm install
b4e6b78 
Signed-off-by: Jeromy Cannon <[email protected]>
@hashgraph hashgraph deleted a comment from alex-kuzmin-hg Dec 16, 2024
@jeromy-cannon
added todo
2335828 
Signed-off-by: Jeromy Cannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy will be requested when the pull request is marked ready for review leninmehedy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@jeromy-cannon jeromy-cannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot install new version: missing key "app.kubernetes.io/managed-by"
1 participant
@jeromy-cannon