feat: solo context connect for single cluster #993

Ivo-Yankov · 2024-12-16T14:08:46Z

Description

This pull request changes the following:

TBD

Related Issues

Closes Implement solo context connect - connects to a deployment and pulls back the RemoteConfig for single cluster deployment #755
Closes bug: solo context connect prompts for cluster after already supplied #951
Closes add a flag to pass email address into solo context connect #950

Signed-off-by: Ivo Yankov <[email protected]>

…ect-connects-to-a-deployment-and-pulls-back-the-remoteconfig-for-single-cluster-deployment

Signed-off-by: Ivo Yankov <[email protected]>

…s-to-a-deployment-and-pulls-back-the-remoteconfig-for-single-cluster-deployment

…ect-connects-to-a-deployment-and-pulls-back-the-remoteconfig-for-single-cluster-deployment

Signed-off-by: Ivo Yankov <[email protected]>

…s-to-a-deployment-and-pulls-back-the-remoteconfig-for-single-cluster-deployment

github-actions · 2024-12-16T14:10:35Z

Unit Test Results - Linux

1 files ±0 58 suites +1 4s ⏱️ -1s
229 tests +9 229 ✅ +9 0 💤 ±0 0 ❌ ±0
239 runs +9 239 ✅ +9 0 💤 ±0 0 ❌ ±0

Results for commit 8a6d1d9. ± Comparison against base commit a4ef700.

This pull request removes 8 and adds 17 tests. Note that renamed tests count towards both.

should not set invalid context mappings ‑ LocalConfig should not set invalid context mappings
should prompt for all flags if none are provided ‑ ContextCommandTasks unit tests updateLocalConfig should prompt for all flags if none are provided
should prompt for cluster if no value is provided ‑ ContextCommandTasks unit tests updateLocalConfig should prompt for cluster if no value is provided
should prompt for context if no value is provided ‑ ContextCommandTasks unit tests updateLocalConfig should prompt for context if no value is provided
should prompt for namespace if no value is provided ‑ ContextCommandTasks unit tests updateLocalConfig should prompt for namespace if no value is provided
should update local configuration with provided values ‑ ContextCommandTasks unit tests updateLocalConfig should update local configuration with provided values
should use cluster from kubectl if no value is provided and quiet=true ‑ ContextCommandTasks unit tests updateLocalConfig should use cluster from kubectl if no value is provided and quiet=true
should use namespace from kubectl if no value is provided and quiet=true ‑ ContextCommandTasks unit tests updateLocalConfig should use namespace from kubectl if no value is provided and quiet=true

should not set invalid clusterContextMapping ‑ LocalConfig should not set invalid clusterContextMapping
should prompt for clusters and contexts if selected deployment is not found in local config ‑ ContextCommandTasks unit tests selectContext should prompt for clusters and contexts if selected deployment is not found in local config
should prompt for context if selected cluster is not found in local config mapping ‑ ContextCommandTasks unit tests selectContext should prompt for context if selected cluster is not found in local config mapping
should prompt for context if selected deployment is found in local config but the context is not ‑ ContextCommandTasks unit tests selectContext should prompt for context if selected deployment is found in local config but the context is not
should set clusterContextMapping ‑ LocalConfig should set clusterContextMapping
should throw a validation error if clusterContextMapping format is not correct ‑ LocalConfig should throw a validation error if clusterContextMapping format is not correct
should update clusterContextMapping with provided context ‑ ContextCommandTasks unit tests updateLocalConfig should update clusterContextMapping with provided context
should update currentDeployment with clusters from remoteConfig ‑ ContextCommandTasks unit tests updateLocalConfig should update currentDeployment with clusters from remoteConfig
should update multiple clusterContextMappings with default KubeConfig context if quiet=true ‑ ContextCommandTasks unit tests updateLocalConfig should update multiple clusterContextMappings with default KubeConfig context if quiet=true
should update multiple clusterContextMappings with prompted context no value was provided ‑ ContextCommandTasks unit tests updateLocalConfig should update multiple clusterContextMappings with prompted context no value was provided
…

♻️ This comment has been updated with latest results.

github-actions · 2024-12-16T14:12:25Z

Unit Test Results - Windows

1 files ±0 58 suites +1 13s ⏱️ -1s
229 tests +9 229 ✅ +9 0 💤 ±0 0 ❌ ±0
239 runs +9 239 ✅ +9 0 💤 ±0 0 ❌ ±0

Results for commit 8a6d1d9. ± Comparison against base commit a4ef700.

This pull request removes 8 and adds 17 tests. Note that renamed tests count towards both.

should not set invalid context mappings ‑ LocalConfig should not set invalid context mappings
should prompt for all flags if none are provided ‑ ContextCommandTasks unit tests updateLocalConfig should prompt for all flags if none are provided
should prompt for cluster if no value is provided ‑ ContextCommandTasks unit tests updateLocalConfig should prompt for cluster if no value is provided
should prompt for context if no value is provided ‑ ContextCommandTasks unit tests updateLocalConfig should prompt for context if no value is provided
should prompt for namespace if no value is provided ‑ ContextCommandTasks unit tests updateLocalConfig should prompt for namespace if no value is provided
should update local configuration with provided values ‑ ContextCommandTasks unit tests updateLocalConfig should update local configuration with provided values
should use cluster from kubectl if no value is provided and quiet=true ‑ ContextCommandTasks unit tests updateLocalConfig should use cluster from kubectl if no value is provided and quiet=true
should use namespace from kubectl if no value is provided and quiet=true ‑ ContextCommandTasks unit tests updateLocalConfig should use namespace from kubectl if no value is provided and quiet=true

should not set invalid clusterContextMapping ‑ LocalConfig should not set invalid clusterContextMapping
should prompt for clusters and contexts if selected deployment is not found in local config ‑ ContextCommandTasks unit tests selectContext should prompt for clusters and contexts if selected deployment is not found in local config
should prompt for context if selected cluster is not found in local config mapping ‑ ContextCommandTasks unit tests selectContext should prompt for context if selected cluster is not found in local config mapping
should prompt for context if selected deployment is found in local config but the context is not ‑ ContextCommandTasks unit tests selectContext should prompt for context if selected deployment is found in local config but the context is not
should set clusterContextMapping ‑ LocalConfig should set clusterContextMapping
should throw a validation error if clusterContextMapping format is not correct ‑ LocalConfig should throw a validation error if clusterContextMapping format is not correct
should update clusterContextMapping with provided context ‑ ContextCommandTasks unit tests updateLocalConfig should update clusterContextMapping with provided context
should update currentDeployment with clusters from remoteConfig ‑ ContextCommandTasks unit tests updateLocalConfig should update currentDeployment with clusters from remoteConfig
should update multiple clusterContextMappings with default KubeConfig context if quiet=true ‑ ContextCommandTasks unit tests updateLocalConfig should update multiple clusterContextMappings with default KubeConfig context if quiet=true
should update multiple clusterContextMappings with prompted context no value was provided ‑ ContextCommandTasks unit tests updateLocalConfig should update multiple clusterContextMappings with prompted context no value was provided
…

♻️ This comment has been updated with latest results.

jeromy-cannon · 2024-12-17T13:28:03Z

src/commands/context/tasks.ts

+    });
+  }
+
+  selectContext(argv) {


would be good to make this method more modular, it is a bit long and has opportunities to be broken down

Signed-off-by: Ivo Yankov <[email protected]>

jeromy-cannon · 2024-12-17T13:31:18Z

src/core/templates.ts

@@ -255,8 +255,8 @@ export class Templates {
    return mapping;
  }

-  static parseClusterAliases(clusters: string) {
-    return clusters ? clusters.split(',') : [];
+  static parseCommaSeparatedList(data: string) {


I think helpers.splitFlagInput would do the same thing and we can remove this.

Signed-off-by: Ivo Yankov <[email protected]>

…s-to-a-deployment-and-pulls-back-the-remoteconfig-for-single-cluster-deployment

Signed-off-by: Ivo Yankov <[email protected]>

github-actions · 2024-12-17T15:55:24Z

E2E Test Report

16 files ±0 121 suites ±0 1h 18m 52s ⏱️ -13s
256 tests ±0 256 ✅ ±0 0 💤 ±0 0 ❌ ±0
259 runs ±0 259 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 8a6d1d9. ± Comparison against base commit a4ef700.

♻️ This comment has been updated with latest results.

codacy-production · 2024-12-17T15:55:40Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.07% (target: -1.00%)	✅ 77.19%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`a4ef700`)	19197	16504	85.97%
Head commit (`8a6d1d9`)	19475 (+278)	16730 (+226)	85.91% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#993)	320	247	77.19%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2024-12-17T15:57:11Z

Codecov Report

Attention: Patch coverage is 77.18750% with 73 lines in your changes missing coverage. Please review.

Project coverage is 84.92%. Comparing base (a4ef700) to head (8a6d1d9).

Files with missing lines	Patch %	Lines
src/core/config/local_config.ts	31.70%	56 Missing ⚠️
src/commands/context/configs.ts	78.04%	9 Missing ⚠️
src/commands/context/handlers.ts	61.53%	5 Missing ⚠️
src/commands/context/tasks.ts	98.48%	2 Missing ⚠️
src/commands/flags.ts	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
- Coverage   84.99%   84.92%   -0.08%     
==========================================
  Files          71       72       +1     
  Lines       19225    19475     +250     
  Branches     1305     1919     +614     
==========================================
+ Hits        16341    16539     +198     
+ Misses       2858     2768      -90     
- Partials       26      168     +142

Files with missing lines	Coverage Δ
src/commands/base.ts	`95.39% <100.00%> (+0.17%)`	⬆️
src/commands/context/flags.ts	`100.00% <100.00%> (ø)`
src/commands/context/index.ts	`63.49% <100.00%> (ø)`
src/core/error_messages.ts	`100.00% <100.00%> (ø)`
src/core/helpers.ts	`89.35% <100.00%> (+0.28%)`	⬆️
src/core/templates.ts	`72.46% <ø> (-0.40%)`	⬇️
src/core/validator_decorators.ts	`98.71% <100.00%> (+0.80%)`	⬆️
src/commands/flags.ts	`78.51% <66.66%> (ø)`
src/commands/context/tasks.ts	`93.65% <98.48%> (+5.89%)`	⬆️
src/commands/context/handlers.ts	`64.51% <61.53%> (+1.05%)`	⬆️
... and 2 more

... and 29 files with indirect coverage changes

Ivo-Yankov added 9 commits December 10, 2024 16:32

feat: update local with remote config

6157203

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'refs/heads/main' into 00755-implement-solo-context-conn…

e9cd551

…ect-connects-to-a-deployment-and-pulls-back-the-remoteconfig-for-single-cluster-deployment

fix: add email flag

589058b

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'main' into 00755-implement-solo-context-connect-connect…

fb39b9a

…s-to-a-deployment-and-pulls-back-the-remoteconfig-for-single-cluster-deployment

Merge branch 'refs/heads/main' into 00755-implement-solo-context-conn…

ea6ff2c

…ect-connects-to-a-deployment-and-pulls-back-the-remoteconfig-for-single-cluster-deployment

feat: reintroduce cluster-context mapping

1980841

Signed-off-by: Ivo Yankov <[email protected]>

wip: rework context connect command

b5c23c1

Signed-off-by: Ivo Yankov <[email protected]>

feat: connect to single cluster

948d7e4

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'main' into 00755-implement-solo-context-connect-connect…

57961a9

…s-to-a-deployment-and-pulls-back-the-remoteconfig-for-single-cluster-deployment

Ivo-Yankov changed the title ~~feat: implement solo context connect for single cluster~~ feat: solo context connect for single cluster Dec 16, 2024

Ivo-Yankov self-assigned this Dec 16, 2024

jeromy-cannon reviewed Dec 17, 2024

View reviewed changes

feat: add unit tests

ff0c529

Signed-off-by: Ivo Yankov <[email protected]>

jeromy-cannon reviewed Dec 17, 2024

View reviewed changes

Ivo-Yankov added 4 commits December 17, 2024 16:46

chore: code cleanup

9f910d3

Signed-off-by: Ivo Yankov <[email protected]>

chore: run formatter

ca0df55

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'main' into 00755-implement-solo-context-connect-connect…

c7b87de

…s-to-a-deployment-and-pulls-back-the-remoteconfig-for-single-cluster-deployment

chore: fix build

8a6d1d9

Signed-off-by: Ivo Yankov <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: solo context connect for single cluster #993

feat: solo context connect for single cluster #993

Ivo-Yankov commented Dec 16, 2024 •

edited

Loading

github-actions bot commented Dec 16, 2024 •

edited

Loading

github-actions bot commented Dec 16, 2024 •

edited

Loading

jeromy-cannon Dec 17, 2024

jeromy-cannon Dec 17, 2024

github-actions bot commented Dec 17, 2024 •

edited

Loading

codacy-production bot commented Dec 17, 2024

codecov bot commented Dec 17, 2024

feat: solo context connect for single cluster #993

Are you sure you want to change the base?

feat: solo context connect for single cluster #993

Conversation

Ivo-Yankov commented Dec 16, 2024 • edited Loading

Description

Related Issues

github-actions bot commented Dec 16, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Dec 16, 2024 • edited Loading

Unit Test Results - Windows

jeromy-cannon Dec 17, 2024

Choose a reason for hiding this comment

jeromy-cannon Dec 17, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 17, 2024 • edited Loading

E2E Test Report

codacy-production bot commented Dec 17, 2024

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Dec 17, 2024

Codecov Report

Ivo-Yankov commented Dec 16, 2024 •

edited

Loading

github-actions bot commented Dec 16, 2024 •

edited

Loading

github-actions bot commented Dec 16, 2024 •

edited

Loading

github-actions bot commented Dec 17, 2024 •

edited

Loading