fix: download application.properties file if it was generated by hedera app during handling address book change #571

JeffreyDallas · 2024-09-12T21:13:00Z

Description

This pull request changes the following:

Download application.properties file if it was generated by hedera app during handling address book change

Related Issues

Closes Use application.properties generated by platform #560

Signed-off-by: Jeffrey Tang <[email protected]>

…vm-debugger Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # test/e2e/commands/node-local-ptt.test.mjs

Signed-off-by: Jeffrey Tang <[email protected]>

…vm-debugger Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/node.mjs

Signed-off-by: Jeffrey Tang <[email protected]>

…vm-debugger Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/flags.mjs # src/commands/network.mjs

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Signed-off-by: Jeffrey Tang <[email protected]>

…steps-reuse Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/node.mjs

Signed-off-by: Jeffrey Tang <[email protected]>

…roperties Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/node.mjs

github-actions · 2024-09-12T21:15:19Z

Unit Test Results - Linux

1 files 19 suites 24s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
148 runs 148 ✅ 0 💤 0 ❌

Results for commit d81e3e9.

github-actions · 2024-09-12T21:16:19Z

Unit Test Results - Windows

1 files 19 suites 51s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
148 runs 148 ✅ 0 💤 0 ❌

Results for commit d81e3e9.

github-actions · 2024-09-12T21:18:36Z

E2E Relay Tests Coverage Report

1 files 1 suites 2m 31s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs 7 ✅ 0 💤 0 ❌

Results for commit d81e3e9.

github-actions · 2024-09-12T21:18:44Z

E2E Node PEM Stop Tests Coverage Report

13 tests 13 ✅ 2m 37s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit d81e3e9.

github-actions · 2024-09-12T21:19:13Z

E2E Mirror Node Tests Coverage Report

1 files 1 suites 3m 28s ⏱️
13 tests 13 ✅ 0 💤 0 ❌
14 runs 14 ✅ 0 💤 0 ❌

Results for commit d81e3e9.

github-actions · 2024-09-12T21:19:44Z

E2E Standard Tests Coverage Report

1 files 9 suites 3m 34s ⏱️
58 tests 58 ✅ 0 💤 0 ❌
59 runs 59 ✅ 0 💤 0 ❌

Results for commit d81e3e9.

github-actions · 2024-09-12T21:20:18Z

E2E Node PEM Kill Tests Coverage Report

13 tests 13 ✅ 2m 46s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit d81e3e9.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-12T21:20:45Z

E2E Node Update Tests Coverage Report

12 tests 12 ✅ 4m 39s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit d81e3e9.

github-actions · 2024-09-12T21:21:44Z

E2E Node Local Build Tests Coverage Report

10 tests 10 ✅ 2m 16s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit d81e3e9.

github-actions · 2024-09-12T21:21:57Z

E2E Node Delete Tests Coverage Report

10 tests 10 ✅ 5m 40s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit d81e3e9.

github-actions · 2024-09-12T21:31:19Z

E2E Node Add Tests Coverage Report

22 tests 22 ✅ 12m 3s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit d81e3e9.

codacy-production · 2024-09-13T01:14:53Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `ae97fc0`¹	✅ 50.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`ae97fc0`)	Report Missing	Report Missing	Report Missing
Head commit (`d81e3e9`)	3971	3263	82.17%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#571)	2	1	50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2024-09-13T01:15:14Z

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.07%. Comparing base (32dcf0c) to head (d81e3e9).
Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/node.mjs	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   82.54%   82.07%   -0.47%     
==========================================
  Files          36       36              
  Lines        4720     4771      +51     
  Branches      674      679       +5     
==========================================
+ Hits         3896     3916      +20     
- Misses        824      855      +31

Files with missing lines	Coverage Δ
src/commands/node.mjs	`82.65% <50.00%> (-0.07%)`	⬇️

## [0.30.0](v0.29.0...v0.30.0) (2024-09-17) ### Features * add node add-prepare and node add-execute commands ([#533](#533)) ([a184775](a184775)) * add support for attach jvm debugger ([#549](#549)) ([35a0075](35a0075)) * add the autogen tool to easily add e2e tests and run it for the first time & fix copyFrom ([#566](#566)) ([e6c79eb](e6c79eb)) * **network node livecheck:** implement a functionality to determine network node activeness with prometheus metrics ([#567](#567)) ([6120775](6120775)) * remove pfx support ([#537](#537)) ([aff5f63](aff5f63)) ### Bug Fixes * aligned test names to naming pattern ([#554](#554)) ([365f724](365f724)) * download application.properties file if it was generated by hedera app during handling address book change ([#571](#571)) ([35c73d8](35c73d8)) * **functionality:** removed the 'z' from the 'tar' command on the K8.copyFrom ([#561](#561)) ([796474b](796474b)) * have update readme run after version calculation in deploy and release ([#586](#586)) ([42e1685](42e1685)) * jsdoc errors due to unrecognized format ([#557](#557)) ([da7113b](da7113b)) * remove of using agreement key in hedera repo test ([#563](#563)) ([05c5517](05c5517)) * separate repeated steps as individual functions ([#562](#562)) ([dcbbe5e](dcbbe5e))

swirlds-automation · 2024-09-17T19:29:05Z

🎉 This PR is included in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

JeffreyDallas and others added 30 commits September 4, 2024 14:40

save

59709d4

Signed-off-by: Jeffrey Tang <[email protected]>

add flags

af17639

Signed-off-by: Jeffrey Tang <[email protected]>

save

cee93a5

Signed-off-by: Jeffrey Tang <[email protected]>

save

8e13fe7

Signed-off-by: Jeffrey Tang <[email protected]>

save

66e36ec

Signed-off-by: Jeffrey Tang <[email protected]>

save

f35489d

Signed-off-by: Jeffrey Tang <[email protected]>

Merge commit 'f639a3b4da7d138f07f18e672b7c337514d52a28' into 0298-D-j…

f790aae

…vm-debugger Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # test/e2e/commands/node-local-ptt.test.mjs

save

e541342

Signed-off-by: Jeffrey Tang <[email protected]>

format check

d01c0b6

Signed-off-by: Jeffrey Tang <[email protected]>

revert

b779c6b

Signed-off-by: Jeffrey Tang <[email protected]>

refactor

94e7330

Signed-off-by: Jeffrey Tang <[email protected]>

save

4034ef6

Signed-off-by: Jeffrey Tang <[email protected]>

save

9fb0e5a

Signed-off-by: Jeffrey Tang <[email protected]>

save

0684d6f

Signed-off-by: Jeffrey Tang <[email protected]>

save

3522f13

Signed-off-by: Jeffrey Tang <[email protected]>

check

00bf06b

Signed-off-by: Jeffrey Tang <[email protected]>

check

7715c47

Signed-off-by: Jeffrey Tang <[email protected]>

Merge commit 'cf23325e94f9d2cb81ab163b9b9f299b96290149' into 0298-D-j…

b670911

…vm-debugger Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/node.mjs

check

4cee5e7

Signed-off-by: Jeffrey Tang <[email protected]>

Merge commit '12142c237b659419f0785820bc1016a753f9af15' into 0298-D-j…

6969bcf

…vm-debugger Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/flags.mjs # src/commands/network.mjs

Update README.md.template

c4ec364

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update README.md.template

4e49809

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update README.md.template

76b0630

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update README.md.template

9f3a38c

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update README.md.template

5fb784c

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

fix: jsdoc errors

d72ab4c

Signed-off-by: Jeffrey Tang <[email protected]>

save

ed06b26

Signed-off-by: Jeffrey Tang <[email protected]>

Merge branch '0298-D-jvm-debugger' into 00558-D-steps-reuse

ebfb7d5

Signed-off-by: Jeffrey Tang <[email protected]>

save

9bcd7eb

Signed-off-by: Jeffrey Tang <[email protected]>

save

220c042

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas added 7 commits September 10, 2024 23:01

save

999097b

Signed-off-by: Jeffrey Tang <[email protected]>

Merge commit '36ce6045880b0ec828742c29c1498aeb9ba51045' into 00558-D-…

3c52164

…steps-reuse Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/node.mjs

check

26bbe34

Signed-off-by: Jeffrey Tang <[email protected]>

save

0e84ccb

Signed-off-by: Jeffrey Tang <[email protected]>

save

2df8689

Signed-off-by: Jeffrey Tang <[email protected]>

copy application proproperties if exist

ed42133

Signed-off-by: Jeffrey Tang <[email protected]>

Merge commit 'ae97fc08c969f0a0eebfd973df80087eeccc36cf' into 0560-D-p…

d81e3e9

…roperties Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/node.mjs

JeffreyDallas requested review from leninmehedy and a team as code owners September 12, 2024 21:13

JeffreyDallas requested a review from jeromy-cannon September 13, 2024 15:03

jeromy-cannon assigned JeffreyDallas Sep 14, 2024

jeromy-cannon approved these changes Sep 14, 2024

View reviewed changes

jeromy-cannon merged commit 35c73d8 into main Sep 14, 2024
38 of 40 checks passed

jeromy-cannon deleted the 0560-D-properties branch September 14, 2024 08:36

swirlds-automation added the released label Sep 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: download application.properties file if it was generated by hedera app during handling address book change #571

fix: download application.properties file if it was generated by hedera app during handling address book change #571

JeffreyDallas commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

codacy-production bot commented Sep 13, 2024

codecov bot commented Sep 13, 2024 •

edited

Loading

swirlds-automation commented Sep 17, 2024

fix: download application.properties file if it was generated by hedera app during handling address book change #571

fix: download application.properties file if it was generated by hedera app during handling address book change #571

Conversation

JeffreyDallas commented Sep 12, 2024

Description

Related Issues

github-actions bot commented Sep 12, 2024

Unit Test Results - Linux

github-actions bot commented Sep 12, 2024

Unit Test Results - Windows

github-actions bot commented Sep 12, 2024

E2E Relay Tests Coverage Report

github-actions bot commented Sep 12, 2024

E2E Node PEM Stop Tests Coverage Report

github-actions bot commented Sep 12, 2024

E2E Mirror Node Tests Coverage Report

github-actions bot commented Sep 12, 2024

E2E Standard Tests Coverage Report

github-actions bot commented Sep 12, 2024 • edited Loading

E2E Node PEM Kill Tests Coverage Report

github-actions bot commented Sep 12, 2024

E2E Node Update Tests Coverage Report

github-actions bot commented Sep 12, 2024

E2E Node Local Build Tests Coverage Report

github-actions bot commented Sep 12, 2024

E2E Node Delete Tests Coverage Report

github-actions bot commented Sep 12, 2024

E2E Node Add Tests Coverage Report

codacy-production bot commented Sep 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented Sep 13, 2024 • edited Loading

Codecov Report

swirlds-automation commented Sep 17, 2024

github-actions bot commented Sep 12, 2024 •

edited

Loading

codecov bot commented Sep 13, 2024 •

edited

Loading