fix: remove of using agreement key in hedera repo test #563

JeffreyDallas · 2024-09-11T17:07:57Z

Description

This pull request changes the following:

Remove of using agreement key in hedera repo test

Related Issues

Closes Drop the agreement gossip key, it is auto generated in 0.51.x and above #501

…rm-agreementkey Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/core/key_manager.mjs # src/core/platform_installer.mjs # test/test_util.js

Signed-off-by: Jeffrey Tang <[email protected]>

github-actions · 2024-09-11T17:09:58Z

Unit Test Results - Linux

1 files ±0 19 suites ±0 25s ⏱️ ±0s
121 tests - 1 121 ✅ - 1 0 💤 ±0 0 ❌ ±0
147 runs - 1 147 ✅ - 1 0 💤 ±0 0 ❌ ±0

Results for commit 5a5f0f8. ± Comparison against base commit 32dcf0c.

This pull request removes 1 test.

KeyManager should generate agreement key ‑ KeyManager should generate agreement key

♻️ This comment has been updated with latest results.

github-actions · 2024-09-11T17:11:03Z

Unit Test Results - Windows

1 files ±0 19 suites ±0 53s ⏱️ +3s
121 tests - 1 121 ✅ - 1 0 💤 ±0 0 ❌ ±0
147 runs - 1 147 ✅ - 1 0 💤 ±0 0 ❌ ±0

Results for commit 5a5f0f8. ± Comparison against base commit 32dcf0c.

This pull request removes 1 test.

KeyManager should generate agreement key ‑ KeyManager should generate agreement key

♻️ This comment has been updated with latest results.

github-actions · 2024-09-11T17:13:21Z

E2E Node PEM Stop Tests Coverage Report

13 tests ±0 13 ✅ ±0 2m 36s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 5a5f0f8. ± Comparison against base commit 32dcf0c.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-11T17:13:31Z

E2E Relay Tests Coverage Report

1 files ±0 1 suites ±0 2m 32s ⏱️ -2s
6 tests ±0 6 ✅ ±0 0 💤 ±0 0 ❌ ±0
7 runs ±0 7 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 5a5f0f8. ± Comparison against base commit 32dcf0c.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-11T17:14:14Z

E2E Mirror Node Tests Coverage Report

1 files ±0 1 suites ±0 3m 53s ⏱️ +22s
13 tests ±0 13 ✅ ±0 0 💤 ±0 0 ❌ ±0
14 runs ±0 14 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 5a5f0f8. ± Comparison against base commit 32dcf0c.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-11T17:15:09Z

E2E Node PEM Kill Tests Coverage Report

13 tests ±0 13 ✅ ±0 2m 48s ⏱️ -1s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 5a5f0f8. ± Comparison against base commit 32dcf0c.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-11T17:15:10Z

E2E Tests Coverage Report

58 tests ±0 58 ✅ ±0 4m 30s ⏱️ +51s
9 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 5a5f0f8. ± Comparison against base commit 32dcf0c.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-11T17:16:21Z

E2E Node Update Tests Coverage Report

12 tests ±0 12 ✅ ±0 4m 38s ⏱️ -7s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 5a5f0f8. ± Comparison against base commit 32dcf0c.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-11T17:17:07Z

E2E Node Local Build Tests Coverage Report

10 tests ±0 10 ✅ ±0 2m 25s ⏱️ +3s
2 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 5a5f0f8. ± Comparison against base commit 32dcf0c.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-11T17:17:07Z

E2E Node Delete Tests Coverage Report

10 tests ±0 10 ✅ ±0 5m 52s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 5a5f0f8. ± Comparison against base commit 32dcf0c.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-11T18:29:32Z

E2E Node Add Tests Coverage Report

22 tests ±0 22 ✅ ±0 12m 52s ⏱️ +33s
2 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 5a5f0f8. ± Comparison against base commit 32dcf0c.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeffrey Tang <[email protected]>

codacy-production · 2024-09-11T22:17:14Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.34% (target: -1.00%)	✅ 0.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`32dcf0c`)	3918	3108	79.33%
Head commit (`5a5f0f8`)	3902 (-16)	3082 (-26)	78.99% (-0.34%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#563)	1	0	0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2024-09-11T22:17:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.13%. Comparing base (32dcf0c) to head (5a5f0f8).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   82.54%   82.13%   -0.41%     
==========================================
  Files          36       36              
  Lines        4720     4696      -24     
  Branches      674      677       +3     
==========================================
- Hits         3896     3857      -39     
- Misses        824      839      +15

Files with missing lines	Coverage Δ
src/commands/flags.mjs	`95.89% <ø> (-0.11%)`	⬇️
src/commands/node.mjs	`82.63% <100.00%> (-0.09%)`	⬇️
src/core/constants.mjs	`94.31% <ø> (-0.07%)`	⬇️
src/core/key_manager.mjs	`80.89% <ø> (-9.16%)`	⬇️
src/core/platform_installer.mjs	`88.61% <ø> (-0.19%)`	⬇️
test/test_util.js	`91.15% <ø> (-0.06%)`	⬇️

The base branch was changed.

…rm-agreementkey Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # .github/workflows/zxc-e2e-test.yaml # src/core/constants.mjs # test/test_util.js # version.mjs

## [0.30.0](v0.29.0...v0.30.0) (2024-09-17) ### Features * add node add-prepare and node add-execute commands ([#533](#533)) ([a184775](a184775)) * add support for attach jvm debugger ([#549](#549)) ([35a0075](35a0075)) * add the autogen tool to easily add e2e tests and run it for the first time & fix copyFrom ([#566](#566)) ([e6c79eb](e6c79eb)) * **network node livecheck:** implement a functionality to determine network node activeness with prometheus metrics ([#567](#567)) ([6120775](6120775)) * remove pfx support ([#537](#537)) ([aff5f63](aff5f63)) ### Bug Fixes * aligned test names to naming pattern ([#554](#554)) ([365f724](365f724)) * download application.properties file if it was generated by hedera app during handling address book change ([#571](#571)) ([35c73d8](35c73d8)) * **functionality:** removed the 'z' from the 'tar' command on the K8.copyFrom ([#561](#561)) ([796474b](796474b)) * have update readme run after version calculation in deploy and release ([#586](#586)) ([42e1685](42e1685)) * jsdoc errors due to unrecognized format ([#557](#557)) ([da7113b](da7113b)) * remove of using agreement key in hedera repo test ([#563](#563)) ([05c5517](05c5517)) * separate repeated steps as individual functions ([#562](#562)) ([dcbbe5e](dcbbe5e))

swirlds-automation · 2024-09-17T19:29:02Z

🎉 This PR is included in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

JeffreyDallas added 6 commits September 6, 2024 11:51

feat: remove agreetment key

7b2bc6e

Merge commit '12142c237b659419f0785820bc1016a753f9af15' into 00501-D-…

5f03746

…rm-agreementkey Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/core/key_manager.mjs # src/core/platform_installer.mjs # test/test_util.js

save

b146968

Signed-off-by: Jeffrey Tang <[email protected]>

save

59bf793

Signed-off-by: Jeffrey Tang <[email protected]>

save

daa00d5

Signed-off-by: Jeffrey Tang <[email protected]>

Merge branch 'test-hedera-0.54' into 00501-D-rm-agreementkey

10236af

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas requested review from a team and leninmehedy as code owners September 11, 2024 17:07

JeffreyDallas added 3 commits September 11, 2024 15:56

save

fb1a5fa

Signed-off-by: Jeffrey Tang <[email protected]>

retry

81aabde

Signed-off-by: Jeffrey Tang <[email protected]>

Merge branch 'test-hedera-0.54' into 00501-D-rm-agreementkey

9493b5b

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas requested a review from jeromy-cannon September 11, 2024 22:12

JeffreyDallas changed the base branch from main to test-hedera-0.54 September 12, 2024 13:55

jeromy-cannon assigned JeffreyDallas Sep 12, 2024

jeromy-cannon previously approved these changes Sep 12, 2024

View reviewed changes

Base automatically changed from test-hedera-0.54 to main September 12, 2024 19:53

jeromy-cannon previously approved these changes Sep 12, 2024

View reviewed changes

Merge commit '32dcf0cc0dac65e17d199c97e554e5b5e21041c9' into 00501-D-…

5a5f0f8

…rm-agreementkey Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # .github/workflows/zxc-e2e-test.yaml # src/core/constants.mjs # test/test_util.js # version.mjs

JeffreyDallas dismissed jeromy-cannon’s stale review via 5a5f0f8 September 12, 2024 20:54

jeromy-cannon approved these changes Sep 14, 2024

View reviewed changes

jeromy-cannon merged commit 05c5517 into main Sep 14, 2024
39 of 40 checks passed

jeromy-cannon deleted the 00501-D-rm-agreementkey branch September 14, 2024 08:40

swirlds-automation added the released label Sep 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove of using agreement key in hedera repo test #563

fix: remove of using agreement key in hedera repo test #563

JeffreyDallas commented Sep 11, 2024

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

codacy-production bot commented Sep 11, 2024 •

edited

Loading

codecov bot commented Sep 11, 2024 •

edited

Loading

swirlds-automation commented Sep 17, 2024

fix: remove of using agreement key in hedera repo test #563

fix: remove of using agreement key in hedera repo test #563

Conversation

JeffreyDallas commented Sep 11, 2024

Description

Related Issues

github-actions bot commented Sep 11, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Sep 11, 2024 • edited Loading

Unit Test Results - Windows

github-actions bot commented Sep 11, 2024 • edited Loading

E2E Node PEM Stop Tests Coverage Report

github-actions bot commented Sep 11, 2024 • edited Loading

E2E Relay Tests Coverage Report

github-actions bot commented Sep 11, 2024 • edited Loading

E2E Mirror Node Tests Coverage Report

github-actions bot commented Sep 11, 2024 • edited Loading

E2E Node PEM Kill Tests Coverage Report

github-actions bot commented Sep 11, 2024 • edited Loading

E2E Tests Coverage Report

github-actions bot commented Sep 11, 2024 • edited Loading

E2E Node Update Tests Coverage Report

github-actions bot commented Sep 11, 2024 • edited Loading

E2E Node Local Build Tests Coverage Report

github-actions bot commented Sep 11, 2024 • edited Loading

E2E Node Delete Tests Coverage Report

github-actions bot commented Sep 11, 2024 • edited Loading

E2E Node Add Tests Coverage Report

codacy-production bot commented Sep 11, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Sep 11, 2024 • edited Loading

Codecov Report

swirlds-automation commented Sep 17, 2024

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

codacy-production bot commented Sep 11, 2024 •

edited

Loading

codecov bot commented Sep 11, 2024 •

edited

Loading