New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: separate repeated steps as individual functions #562

Merged

jeromy-cannon merged 43 commits into main from 00558-D-steps-reuse

Sep 12, 2024

Contributor

JeffreyDallas commented Sep 11, 2024

Description

This pull request changes the following:

Separate repeated steps as individual functions

Related Issues

Closes Clean up code to reuse some repeated node command steps #558

JeffreyDallas and others added 30 commits

September 4, 2024 14:40


          save

59709d4

Signed-off-by: Jeffrey Tang <[email protected]>


          add flags

af17639

Signed-off-by: Jeffrey Tang <[email protected]>


          save

cee93a5

Signed-off-by: Jeffrey Tang <[email protected]>


          save

8e13fe7

Signed-off-by: Jeffrey Tang <[email protected]>


          save

66e36ec

Signed-off-by: Jeffrey Tang <[email protected]>


          save

f35489d

Signed-off-by: Jeffrey Tang <[email protected]>


          Merge commit 'f639a3b4da7d138f07f18e672b7c337514d52a28' into 0298-D-j…

f790aae

…vm-debugger

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	test/e2e/commands/node-local-ptt.test.mjs


          save

e541342

Signed-off-by: Jeffrey Tang <[email protected]>


          format check

d01c0b6

Signed-off-by: Jeffrey Tang <[email protected]>


          revert

b779c6b

Signed-off-by: Jeffrey Tang <[email protected]>


          refactor

94e7330

Signed-off-by: Jeffrey Tang <[email protected]>


          save

4034ef6

Signed-off-by: Jeffrey Tang <[email protected]>


          save

9fb0e5a

Signed-off-by: Jeffrey Tang <[email protected]>


          save

0684d6f

Signed-off-by: Jeffrey Tang <[email protected]>


          save

3522f13

Signed-off-by: Jeffrey Tang <[email protected]>


          check

00bf06b

Signed-off-by: Jeffrey Tang <[email protected]>


          check

7715c47

Signed-off-by: Jeffrey Tang <[email protected]>


          Merge commit 'cf23325e94f9d2cb81ab163b9b9f299b96290149' into 0298-D-j…

b670911

…vm-debugger

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/node.mjs


          check

4cee5e7

Signed-off-by: Jeffrey Tang <[email protected]>


          Merge commit '12142c237b659419f0785820bc1016a753f9af15' into 0298-D-j…

6969bcf

…vm-debugger

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/flags.mjs
#	src/commands/network.mjs


          Update README.md.template

c4ec364

Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>


          Update README.md.template

4e49809

Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>


          Update README.md.template

76b0630

Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>


          Update README.md.template

9f3a38c

Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>


          Update README.md.template

5fb784c

Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>


          fix: jsdoc errors

d72ab4c

Signed-off-by: Jeffrey Tang <[email protected]>


          save

ed06b26

Signed-off-by: Jeffrey Tang <[email protected]>


          Merge branch '0298-D-jvm-debugger' into 00558-D-steps-reuse

ebfb7d5

Signed-off-by: Jeffrey Tang <[email protected]>


          save

9bcd7eb

Signed-off-by: Jeffrey Tang <[email protected]>


          save

220c042

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas requested review from leninmehedy and a team as code owners

September 11, 2024 13:24

JeffreyDallas self-assigned this

JeffreyDallas marked this pull request as draft

September 11, 2024 13:24

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

Unit Test Results - Linux

1 files 19 suites 27s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
148 runs 148 ✅ 0 💤 0 ❌

Results for commit 2df8689.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

Unit Test Results - Windows

1 files 19 suites 53s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
148 runs 148 ✅ 0 💤 0 ❌

Results for commit 2df8689.

♻️ This comment has been updated with latest results.


          check

26bbe34

Signed-off-by: Jeffrey Tang <[email protected]>

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

E2E Node PEM Stop Tests Coverage Report

13 tests 13 ✅ 2m 37s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 2df8689.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

E2E Relay Tests Coverage Report

1 files 1 suites 2m 43s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs 7 ✅ 0 💤 0 ❌

Results for commit 2df8689.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

E2E Node PEM Kill Tests Coverage Report

13 tests 13 ✅ 2m 58s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 2df8689.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

E2E Mirror Node Tests Coverage Report

1 files 1 suites 3m 50s ⏱️
13 tests 13 ✅ 0 💤 0 ❌
14 runs 14 ✅ 0 💤 0 ❌

Results for commit 2df8689.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

E2E Node Local Build Tests Coverage Report

10 tests 10 ✅ 2m 33s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit 2df8689.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

E2E Tests Coverage Report

58 tests 58 ✅ 4m 23s ⏱️
9 suites 0 💤
1 files 0 ❌

Results for commit 2df8689.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

E2E Node Update Tests Coverage Report

12 tests 12 ✅ 4m 36s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 2df8689.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

E2E Node Delete Tests Coverage Report

10 tests 10 ✅ 5m 48s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 2df8689.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

E2E Node Add Tests Coverage Report

22 tests 22 ✅ 12m 1s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit 2df8689.

♻️ This comment has been updated with latest results.

JeffreyDallas added 2 commits

September 11, 2024 09:14


          save

0e84ccb

Signed-off-by: Jeffrey Tang <[email protected]>


          save

2df8689

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas marked this pull request as ready for review

September 11, 2024 15:27

JeffreyDallas requested a review from jeromy-cannon

September 11, 2024 15:39

jeromy-cannon requested a review from Ivo-Yankov

September 11, 2024 15:45

codacy-production bot commented Sep 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `36ce604`¹	✅ 85.71%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`36ce604`)	Report Missing	Report Missing	Report Missing
Head commit (`2df8689`)	3917	3111	79.42%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#562)	140	120	85.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov bot commented Sep 11, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 98.75776% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (853eb9e) to head (2df8689).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/node.mjs	98.75%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
- Coverage   83.15%   82.60%   -0.56%     
==========================================
  Files          36       36              
  Lines        4815     4714     -101     
  Branches      667      749      +82     
==========================================
- Hits         4004     3894     -110     
- Misses        811      820       +9

Files with missing lines	Coverage Δ
src/commands/node.mjs	`82.80% <98.75%> (-2.28%)`	⬇️

... and 3 files with indirect coverage changes

Contributor

jeromy-cannon commented Sep 12, 2024

LGTM, but I want to let @Ivo-Yankov merge #533 first, as we need that for Simi's team.

jeromy-cannon approved these changes

View reviewed changes

jeromy-cannon merged commit dcbbe5e into main

40 of 41 checks passed

jeromy-cannon deleted the 00558-D-steps-reuse branch

September 12, 2024 17:23

swirlds-automation added a commit that referenced this pull request


          chore(release): 0.30.0 [skip ci]

e20c544

## [0.30.0](v0.29.0...v0.30.0) (2024-09-17)

### Features

* add node add-prepare and node add-execute commands ([#533](#533)) ([a184775](a184775))
* add support for attach jvm debugger ([#549](#549)) ([35a0075](35a0075))
* add the autogen tool to easily add e2e tests and run it for the first time & fix copyFrom ([#566](#566)) ([e6c79eb](e6c79eb))
* **network node livecheck:** implement a functionality to determine network node activeness with prometheus metrics ([#567](#567)) ([6120775](6120775))
* remove pfx support ([#537](#537)) ([aff5f63](aff5f63))

### Bug Fixes

* aligned test names to naming pattern ([#554](#554)) ([365f724](365f724))
* download application.properties file if it was generated by hedera app during handling address book change ([#571](#571)) ([35c73d8](35c73d8))
* **functionality:** removed the 'z' from the 'tar' command on the K8.copyFrom ([#561](#561)) ([796474b](796474b))
* have update readme run after version calculation in deploy and release ([#586](#586)) ([42e1685](42e1685))
* jsdoc errors due to unrecognized format ([#557](#557)) ([da7113b](da7113b))
* remove of using agreement key in hedera repo test ([#563](#563)) ([05c5517](05c5517))
* separate repeated steps as individual functions ([#562](#562)) ([dcbbe5e](dcbbe5e))

Contributor

swirlds-automation commented Sep 17, 2024

🎉 This PR is included in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels