Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mirror node options from solo network deploy to solo mirror-node deploy #431

Closed
Tracked by #47
jeromy-cannon opened this issue Jul 17, 2024 · 1 comment · Fixed by #583
Closed
Tracked by #47

Move mirror node options from solo network deploy to solo mirror-node deploy #431

jeromy-cannon opened this issue Jul 17, 2024 · 1 comment · Fixed by #583
Assignees
@JeffreyDallas
Labels
Improvement Code changes driven by non business requirements P3 Low priority issue. Will not impact the release schedule if not complete. released Tech Debt Changes that are needed to keep up with tech debt

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Jul 17, 2024 •
edited
Loading

The following options are still loaded under solo network deploy; however, they aren't actually used until solo mirror-node deploy and should be moved there.

      flags.deployHederaExplorer,
      flags.deployMirrorNode,
      flags.enableHederaExplorerTls,
      flags.hederaExplorerTlsHostName,
      flags.hederaExplorerTlsLoadBalancerIp,
      flags.tlsClusterIssuerType,

should be done after #136 to avoid conflicts from refactoring
@jeromy-cannon jeromy-cannon mentioned this issue Jul 17, 2024
Open
@jeromy-cannon jeromy-cannon added the P3 Low priority issue. Will not impact the release schedule if not complete. label Jul 17, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Jul 17, 2024
@jeromy-cannon jeromy-cannon moved this from 🆕 New to 🔖 Ready in Solo Jul 17, 2024
@jeromy-cannon jeromy-cannon added Improvement Code changes driven by non business requirements Tech Debt Changes that are needed to keep up with tech debt labels Aug 22, 2024
@JeffreyDallas JeffreyDallas mentioned this issue Sep 16, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Solo Sep 18, 2024
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffreyDallas JeffreyDallas

Labels
Improvement Code changes driven by non business requirements P3 Low priority issue. Will not impact the release schedule if not complete. released Tech Debt Changes that are needed to keep up with tech debt
Projects
Solo
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Relocate flags used for mirror node deployment hashgraph/solo
3 participants
@jeromy-cannon @JeffreyDallas @swirlds-automation