Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do checksum check after fetching platform zip file #111

Closed
Tracked by #47
leninmehedy opened this issue Feb 28, 2024 · 1 comment · Fixed by #125
Closed
Tracked by #47

Do checksum check after fetching platform zip file #111

leninmehedy opened this issue Feb 28, 2024 · 1 comment · Fixed by #125
Assignees
@leninmehedy
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P1 High priority issue. Required to be completed in the assigned milestone. released

Comments

@leninmehedy
Copy link
Member

Recently we modified code so that platform code is directly fetched inside the container: #84

As it is not using PackageDownloader to download first, it doesn't do the checksum check as before: https://github.com/hashgraph/solo/blob/main/src/core/package_downloader.mjs#L208
@leninmehedy leninmehedy self-assigned this Feb 28, 2024
@leninmehedy leninmehedy added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Feb 28, 2024
@leninmehedy leninmehedy mentioned this issue Feb 28, 2024
Merged
@leninmehedy leninmehedy added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. and removed Bug A error that causes the feature to behave differently than what was expected based on design docs labels Feb 28, 2024
@leninmehedy leninmehedy mentioned this issue Feb 29, 2024
Open
@leninmehedy leninmehedy added this to Solo Feb 29, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Feb 29, 2024
@leninmehedy leninmehedy added the P1 High priority issue. Required to be completed in the assigned milestone. label Feb 29, 2024
@leninmehedy leninmehedy moved this from 🆕 New to 🔖 Ready in Solo Feb 29, 2024
@leninmehedy leninmehedy moved this from 🔖 Ready to 🏗 In progress in Solo Mar 5, 2024
@leninmehedy leninmehedy mentioned this issue Mar 5, 2024
Merged
@leninmehedy leninmehedy moved this from 🏗 In progress to ✅ Done in Solo Mar 5, 2024
@leninmehedy leninmehedy moved this from ✅ Done to 👀 In review in Solo Mar 5, 2024
@leninmehedy leninmehedy changed the title Do checksum check when fetching platform zip file Do checksum check after fetching platform zip file Mar 5, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Solo Mar 6, 2024
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leninmehedy leninmehedy

Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P1 High priority issue. Required to be completed in the assigned milestone. released
Projects
Solo
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do checksum check after downloading platform zip file hashgraph/solo
2 participants
@leninmehedy @swirlds-automation