Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for calling isAssociated() via HRC proxy contract #861

Closed
georgi-l95 opened this issue Jul 16, 2024 · 2 comments · Fixed by #905
Closed

Add tests for calling isAssociated() via HRC proxy contract #861

georgi-l95 opened this issue Jul 16, 2024 · 2 comments · Fixed by #905
Assignees
@Ivo-Yankov @quiet-node
Labels
enhancement New feature or request
Milestone
0.9.0

Comments

@georgi-l95
Copy link
Contributor

Problem

Until recently calling isAssociated() was not possible, but now with the resolving of this issue in services, this is possible.

Solution

We'd need to extend our current examples to support and test this behaviour.

Alternatives

No response
@georgi-l95 georgi-l95 added the enhancement New feature or request label Jul 16, 2024
@georgi-l95 georgi-l95 added this to the 0.9.0 milestone Jul 16, 2024
@Nana-EC Nana-EC moved this from Backlog to Sprint Backlog in Smart Contract Sprint Board Jul 18, 2024
@Ivo-Yankov Ivo-Yankov self-assigned this Aug 6, 2024
@Ivo-Yankov
Copy link
Contributor

Ivo-Yankov commented Aug 7, 2024 •
edited
Loading

Тhis issue is blocked for now. The isAssociated method is a view type. This means that whenever it is called it would go through eth_call, which in turn will execute the method in the web3 module of the Mirror node. But the EVM of the mirror node is not yet updated with the opcode for this method.

It will be unblocked when this issue is closed: hashgraph/hedera-mirror-node#8828

@Ivo-Yankov Ivo-Yankov moved this from Tasks In Progress to Blocked in Smart Contract Sprint Board Aug 7, 2024
@Ivo-Yankov Ivo-Yankov assigned Ivo-Yankov and unassigned Ivo-Yankov Aug 7, 2024
@Ivo-Yankov
Copy link
Contributor

This can be unblocked sooner by this: hashgraph/hedera-json-rpc-relay#2810

@Ivo-Yankov Ivo-Yankov mentioned this issue Aug 15, 2024
Merged
2 tasks
@quiet-node quiet-node self-assigned this Sep 14, 2024
@quiet-node quiet-node moved this from Blocked to Tasks In Progress in Smart Contract Sprint Board Sep 14, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ivo-Yankov Ivo-Yankov

@quiet-node quiet-node

Labels
enhancement New feature or request
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

test: add test coverage and example usage for HIP719 isAssociated() hashgraph/hedera-smart-contracts
3 participants
@Ivo-Yankov @georgi-l95 @quiet-node