Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid repeating work in handle sig expansion/verification #1501

Closed
2 tasks done
tinker-michaelj opened this issue May 31, 2021 · 0 comments
Closed
2 tasks done

Avoid repeating work in handle sig expansion/verification #1501

tinker-michaelj opened this issue May 31, 2021 · 0 comments
Assignees
Labels
Performance Issues related to performance concerns.
Milestone

Comments

@tinker-michaelj
Copy link
Collaborator

tinker-michaelj commented May 31, 2021

Summary
There are two simple ways to reduce the cost of signature verification in handleTransaction; both involve re-using information computed in Rationalization.execute().

  • SwirldTransaction.getSignatures() acquires a lock and makes a defensive copy; the finalized List<TransactionSignature> can be set in a field on the scoped TxnAccessor.
  • The AwareProcessLogic and InHandleActivationHelper will also need the payer and other-party required signing keys; these may also be recorded in a TxnAccessor field.
@tinker-michaelj tinker-michaelj added this to the Hedera 0.15.0 milestone May 31, 2021
@tinker-michaelj tinker-michaelj self-assigned this May 31, 2021
@nathanklick nathanklick added Performance Issues related to performance concerns. and removed perf labels Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Issues related to performance concerns.
Projects
None yet
Development

No branches or pull requests

2 participants