Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid expensive stream operations when sourcing public key's sig from sigMap #1423

Closed
tinker-michaelj opened this issue May 17, 2021 · 0 comments · Fixed by #1456
Closed

Avoid expensive stream operations when sourcing public key's sig from sigMap #1423

tinker-michaelj opened this issue May 17, 2021 · 0 comments · Fixed by #1456
Assignees
@Neeharika-Sompalli
Labels
Performance Issues related to performance concerns.
Milestone
Hedera 0.15.0

Comments

@tinker-michaelj
Copy link
Collaborator

Summary
It will be materially faster in SigMapPubKeyToSigBytes.sigBytesFor() if we replace the stream() idiom with a simple for loop over the SignaturePairs in the sigMap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Neeharika-Sompalli Neeharika-Sompalli

Labels
Performance Issues related to performance concerns.
Projects
None yet
Milestone
Hedera 0.15.0
3 participants
@nathanklick @tinker-michaelj @Neeharika-Sompalli