Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete copied code from services in hedera-mirror-web3 #9263

Open
Tracked by #8828
IvanKavaldzhiev opened this issue Sep 3, 2024 · 1 comment
Open
Tracked by #8828

Delete copied code from services in hedera-mirror-web3 #9263

IvanKavaldzhiev opened this issue Sep 3, 2024 · 1 comment
Labels
enhancement Type: New feature web3 Area: Web3 API

Comments

@IvanKavaldzhiev
Copy link
Contributor

Problem

After the reusable services code base is fully integrated and tested inside hedera-mirror-web3, we should delete all of the legacy code that is copied code from services mono, special spring bean definitions of wiring services components and all other not needed models, utilities and unit tests connected to legacy code.

Solution

Delete the following packages and classes:

  • com.hedera.node.app.service
  • com.hedera.services
  • com.hedera.mirror.web3.evm.account
  • com.hedera.mirror.web3.evm.config.ServicesConfiguration
  • com.hedera.mirror.web3.evm.contracts - all files except OpcodesProcessingResult
  • com.hedera.mirror.web3.evm.contracts.operations
  • com.hedera.mirror.web3.evm.contracts.store - all files except the DatabaseAccessors
  • com.hedera.mirror.web3.evm.contracts.store.token

Alternatives

No response

@bilyana-gospodinova
Copy link
Contributor

We need to check the repository methods as well and delete any unused or unneeded methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants