Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AliasesDatabaseReadableKVState #9256

Closed
Tracked by #8828
IvanKavaldzhiev opened this issue Sep 3, 2024 · 0 comments · Fixed by #9527
Closed
Tracked by #8828

Implement AliasesDatabaseReadableKVState #9256

IvanKavaldzhiev opened this issue Sep 3, 2024 · 0 comments · Fixed by #9527
Assignees
Labels
enhancement Type: New feature web3 Area: Web3 API
Milestone

Comments

@IvanKavaldzhiev
Copy link
Contributor

IvanKavaldzhiev commented Sep 3, 2024

Problem

We need to add a new type of database accessor to read account aliases, so that we have specific ReadableKVState instance for this type of data.

Solution

Add AliasesDatabaseReadableKVState class that reads account ids by aliases and converts them to AccountID PBJ type.

Add unit tests to cover all cases including historical reads and correct mapping for all fields.

Alternatives

No response

@IvanKavaldzhiev IvanKavaldzhiev added enhancement Type: New feature web3 Area: Web3 API labels Sep 3, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Mirror Node Sep 3, 2024
@IvanKavaldzhiev IvanKavaldzhiev changed the title Add AliasesDatabaseAccessor for reading account aliases Add AliasesDatabaseReadableKVState for reading account aliases Sep 11, 2024
@bilyana-gospodinova bilyana-gospodinova self-assigned this Sep 25, 2024
@bilyana-gospodinova bilyana-gospodinova moved this from 📋 Backlog to 👷 In progress in Mirror Node Sep 27, 2024
@steven-sheehy steven-sheehy added this to the 0.116.0 milestone Sep 29, 2024
@bilyana-gospodinova bilyana-gospodinova moved this from 👷 In progress to 👀 In review in Mirror Node Oct 7, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Mirror Node Oct 11, 2024
@steven-sheehy steven-sheehy changed the title Add AliasesDatabaseReadableKVState for reading account aliases Implement AliasesDatabaseReadableKVState Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants