Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TokenRelationshipDatabaseReadableKVState #9253

Closed
Tracked by #8828
IvanKavaldzhiev opened this issue Sep 3, 2024 · 0 comments · Fixed by #9582
Closed
Tracked by #8828

Implement TokenRelationshipDatabaseReadableKVState #9253

IvanKavaldzhiev opened this issue Sep 3, 2024 · 0 comments · Fixed by #9582
Assignees
Labels
enhancement Type: New feature web3 Area: Web3 API
Milestone

Comments

@IvanKavaldzhiev
Copy link
Contributor

IvanKavaldzhiev commented Sep 3, 2024

Problem

Add implementation for TokenRelationshipDatabaseReadableKVState, so that we can return token relationships in PBJ format from DB.

Solution

Add TokenRelationshipDatabaseReadableKVState in the following manner:

  • Copy TokenRelationshipDatabaseAccessor logic as a starting point
  • Add repository logic for reading token relationships from DB
  • Add a new converter between DTO types to PBJ, so that the returned object is compliant with the hedera.app state

Alternatives

No response

@IvanKavaldzhiev IvanKavaldzhiev added enhancement Type: New feature web3 Area: Web3 API labels Sep 3, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Mirror Node Sep 3, 2024
@IvanKavaldzhiev IvanKavaldzhiev changed the title Refactor existing TokenRelationshipDatabaseAccessor Implement TokenRelationshipDatabaseReadableKVState Sep 11, 2024
@steven-sheehy steven-sheehy moved this from 📋 Backlog to 🏃‍♀ Sprint backlog in Mirror Node Sep 15, 2024
@bilyana-gospodinova bilyana-gospodinova self-assigned this Sep 24, 2024
@bilyana-gospodinova bilyana-gospodinova moved this from 🏃‍♀ Sprint backlog to 👷 In progress in Mirror Node Sep 24, 2024
@bilyana-gospodinova bilyana-gospodinova moved this from 👷 In progress to 🏃‍♀ Sprint backlog in Mirror Node Sep 24, 2024
@steven-sheehy steven-sheehy added this to the 0.116.0 milestone Sep 29, 2024
@steven-sheehy steven-sheehy changed the title Implement TokenRelationshipDatabaseReadableKVState Implement TokenRelationshipDatabaseReadableKVState Oct 11, 2024
@steven-sheehy steven-sheehy modified the milestones: 0.116.0, 0.117.0 Oct 15, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Mirror Node Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants