Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary logic for 501 NOT_SUPPORTED status in web3 #9136

Closed
Tracked by #8828
IvanKavaldzhiev opened this issue Aug 23, 2024 · 0 comments · Fixed by #9189
Closed
Tracked by #8828

Add temporary logic for 501 NOT_SUPPORTED status in web3 #9136

IvanKavaldzhiev opened this issue Aug 23, 2024 · 0 comments · Fixed by #9189
Assignees
Labels
enhancement Type: New feature web3 Area: Web3 API
Milestone

Comments

@IvanKavaldzhiev
Copy link
Contributor

Problem

Currently the hedera-mirror-web3 business logic is based on a copied code of the services mono code base. Services, however, has switched to modularized code base, which will add some new Hedera precompiles, which we can't directly copy in web3. This opens a need to add a logic for throwing exception for unsupported precompiles, so that the json-rpc-relay distinguish between contract revert scenario and a call to unsupported precompile.

Solution

  • Throw custom exception in HTSPrecompiledContract for the cases of calling unsupported precompile
  • Add interceptor in the exception handler advice component for throwing NOT_SUPPORTED error

Alternatives

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant