Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the circular (install) dependency between multiformats and multiformats-config #24

Open
declension opened this issue Jul 15, 2024 · 3 comments

Comments

@declension
Copy link

First of all, thanks for the repo(s)!

I'm using Poetry, and that lead me to notice that multiformat depends on multiformat-config at least at build time, and also, multiformat-config depends on multiformat.

Clearly this isn't technically a problem in Python, but whilst I'm not an expert, it does seem that in Nix it causes trouble (an example with poetry2nix)

Is this a Nix problem, or is there anything that can be done here?

Thanks

@sg495
Copy link
Contributor

sg495 commented Jul 20, 2024

In this case, this seems to be an issue on the Nix side rather than the Python side. But really it is an issue with the current design of multiformats, which pre-initialises its data structures rather than initialising them on-demand. I will re-design the init process at some point in the near future, which will remove the need for multiformat-config altogether. Is this something that is causing you issues right now?

@declension
Copy link
Author

Thanks @sg495 .

It's a non-critical issue I guess, as due the now-solved #10 we'd implemented the bits of the spec we needed manually in Python.

I recently tried pulling in this library again but given we package with Nix ran into this so have paused / halted that idea...

@sg495
Copy link
Contributor

sg495 commented Jul 24, 2024

No problem. I'll keep this open as a reminder to us of the issue, and I'll @ you when it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants