Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to view some images #56

Closed
wannaskoo opened this issue Oct 22, 2021 · 3 comments
Closed

Unable to view some images #56

wannaskoo opened this issue Oct 22, 2021 · 3 comments

Comments

@wannaskoo
Copy link

OS: Android 10
Device: OnePlus 6
Platform: ARM64
DroidFS version: 1.6.0

This happens only when trying to view images bigger than 5MB, it just shows a black screen. I managed to record some logs when opening one of said images.

logcat_10-22-2021_04-47-44.txt

@hardcore-sushi
Copy link
Owner

It works fine on my side, and my phone has less RAM than yours. What's the format of the image that causes the bug? Does it open fine with other apps? Maybe you can share it?

@wannaskoo
Copy link
Author

I did some tests. All the images affected by this issue are png, because all the large images i have are also png (and i didn't notice that until you asked the format lol). I first tried to download, import and view a small png (around 500 KB), with success. Then i tried with a large png (around 8 MB) and i got a black screen. So to double check i converted one of my pngs to jpg and managed to display it without issues and to triple check i downloaded a large jpg (5.30 MB) and it worked.
The pngs open fine with Simple Gallery.
Unfortunately i cannot share any of them. Sorry.

@hardcore-sushi
Copy link
Owner

Fixed: 1cab607
The issue wasn't from DroidFS but from Glide (the library it uses to display images): bumptech/glide#4517 It seems to be fixed but the latest release is from January and doesn't include the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants