helo checks config settings misbehave

[msimerson]

system info

Haraka	Haraka.js — Version: 2.8.13
Node	v7.3.0
OS	FreeBSD haraka 10.3-RELEASE-p7 FreeBSD 10.3-RELEASE-p7 #0: Thu Aug 11 18:38:15 UTC 2016 [email protected]:/usr/obj/usr/src/sys/GENERIC amd64
openssl	OpenSSL 1.0.1s-freebsd 1 Mar 2016

Expected behavior

For helo.checks to behave as documented: by default all checks are enabled, all rejects are disabled. That's what the .md file claims and it's what the default helo.checks.ini file contains, but it's not what the defaults are in helo.checks.load_helo_checks_ini()'s boolean declarations.

Observed behavior

Despite [reject]valid_hostname=false being set in the default config file, and that setting not being present in the local overrides file, that rejection option ends up being enabled.

Steps to reproduce

1. Install Haraka.
2. partially customize helo.checks, such as 'cat "[reject]" >> config/helo.checks.ini
3. establish a connection with an invalid hostname

Step #2 might not be necessary and/or relevant.