We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r-stack
r-stretch
Please see my reproduction (https://github.com/alifeee/revealjs-rstretch-bug) on http://alifeee.co.uk/revealjs-rstretch-bug/
Importantly, here is the markup of the problem slide:
<section data-auto-animate> <h1 data-id="h1"><code>class="r-stack r-stretch"</code></h1> <p> Stack only. On Firefox, limits section to viewport. On Chrome, stretches off bottom of viewport :( </p> <div class="r-stack r-stretch"> <img src="images/wide.png" alt="wide image" /> <img src="images/tall.png" alt="tall image" /> </div> </section>
All is good
All is not good (images stretch off the bottom)
I am not sure why. It seems a difference in how Firefox and Chrome deal with grid layout?
See the grid overlay here, and I have highlighted the div containing the images
div
Div is sized correctly, and grid layout is the same size
Div is sized correctly, but the grid layout overflows past this size
After doing some research, I think I have found a fix. I will create a PR. I will also create this issue for people to find.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Please see my reproduction (https://github.com/alifeee/revealjs-rstretch-bug) on http://alifeee.co.uk/revealjs-rstretch-bug/
Importantly, here is the markup of the problem slide:
Firefox
All is good
Chrome
All is not good (images stretch off the bottom)
Why?
I am not sure why. It seems a difference in how Firefox and Chrome deal with grid layout?
See the grid overlay here, and I have highlighted the
div
containing the imagesFirefox
Div is sized correctly, and grid layout is the same size
Chrome
Div is sized correctly, but the grid layout overflows past this size
Research
After doing some research, I think I have found a fix. I will create a PR. I will also create this issue for people to find.
The text was updated successfully, but these errors were encountered: