Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an option to close doneyet with a well known key combination like ctrl-q #48

Open
stweise opened this issue Sep 21, 2023 · 4 comments

Comments

@stweise
Copy link
Collaborator

stweise commented Sep 21, 2023

Implement an option to close doneyet with a well known key combination like ctrl-q

@Chavao let us talk how to best implement that here

@stweise
Copy link
Collaborator Author

stweise commented Sep 21, 2023

Ctrl+S and Ctrl+Q are XON/XOFF on serial lines and thus should not be used in terminal applications, any terminal application might handle this differently.
The only way to have access to these would be to use ioctl(fd, KDSKBMODE, mode) and use K_RAW or K_MEDIUMRAW

@stweise
Copy link
Collaborator Author

stweise commented Sep 21, 2023

I am now implementing a check mode for us on a branch so that we can verify as best possible across platforms.

will push mention the branch here later

@Chavao
Copy link
Contributor

Chavao commented Sep 21, 2023

What do you think about Shift-q? ncspot uses Shift-q to exit.

@stweise
Copy link
Collaborator Author

stweise commented Sep 22, 2023

Yes, i think that should work.
In the initial PR you replaced the current option to close doneyet by simply pressing 'q'.
Was that intentional, to e.g. prevent accidentally closing it?

I am still trying to understand how to keep the closing of the application command consistent with the other commands, like 'a' to add a task

to illustrate, these are consistent:

  • 'a' add task
  • 'n' add a note to the selected task.
  • 'v' view the notes of the selected task.
  • 'j' select next task
  • ....
  • 'q' quit

so are these:

  • 'shift-a' add task
  • 'shift-n' add a note to the selected task.
  • 'shitft-v' view the notes of the selected task.
  • 'shift-j' select next task
  • ....
  • 'shift-q' quit

this is not, as far as I am concerned:

  • 'a' add task
  • 'n' add a note to the selected task.
  • 'v' view the notes of the selected task.
  • 'j' select next task
  • ....
  • 'shift-q' quit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants