Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 1fd0250 all suspension and extension activity appears affected on some systems #823

Closed
CollinChaffin opened this issue Dec 6, 2018 · 6 comments

Comments

@CollinChaffin
Copy link
Contributor

CollinChaffin commented Dec 6, 2018

EDIT:

It appears after further testing that on at least one system sharing the exact same commit level extension data (coincidentally all recently got another Chrome DEV update) does still function and does NOT (oddly) log the errors in the screenshots below that others are. I have ensured all systems are all on the latest Chrome update level, fully restarted, rebooted, etc. and will update more as I find it but no matter what I have tried cannot make the affected system(s) with the below errors again suspend ANYTHING, and upon even a simple restart of the unpacked extension only those systems IMMEDIATELY upon load generate the errors below, without any tabs except single blank page open. Again, this is a case where reading the log data being generated after the recent refactoring is really needed in cases like this; so any help locating is appreciated.

...as of updating to last night's commit 1fd0250, the entire extension no longer functions to suspend, either automatically or even manually via hotkey or menu.

Again, I saw lots of "logging" utility functions in various commits but without going back through all that code could you possibly indicate whether with a sql viewer etc. how to get to what is being logged by this extension? TIA!

Screenshots of 2 errors generated this run:

snag_12-6-2018_00-19-59
snag_12-6-2018_00-20-06

@CollinChaffin CollinChaffin changed the title Commit 1fd0250 all suspension and extension activity broken! Commit 1fd0250 all suspension and extension activity appears affected on some systems Dec 6, 2018
@CollinChaffin
Copy link
Contributor Author

Update: Looks like this is/was the result of 2 issues - one was fixed with your last commits ending in 83287ac. The other appears to still affect only some systems and revolves around the latest Chrome DEV build (but oddly only appears to affect TGS) (so far as I test). Although like I said when I opened this it was in-between a few related commits that might have only caused the issue being implemented separately.

I'll continue testing and return to either report back more or just close this issue out shortly.

@CollinChaffin
Copy link
Contributor Author

If I roll back to prior build or earlier running the latest commit now once again appears stable. That's the good news. The bad news is that in a month if this Chromium code makes it to stable and this TGS code remains as-is, it will no longer function. Certainly not a down-the-road situation you want to become reality.

The above cross-origin error is the one by itself that appears upon Chrome attempting to init the extension, and because of (I'm theorizing) that new error being severe enough that TGS isn't running and won't function in any respect.

If you can possibly test with the latest (Version 72.0.3626.7 (Official Build) dev (64-bit)) with your debugging and shed light onto what is happening, I'm certain with good detail that you opening a Chromium issue armed with that (rather than my simple test results and no way to generate any logs) will get it assigned to a Chromium DEV and probably resolved within hours.

@CollinChaffin
Copy link
Contributor Author

@deanoemcke Hi Dean! I've asked before but I'm now wasting a considerable amount of time attempting to (unsuccessfully) debug this extension without having any info yet on the debug/logging you've added. I see the debug.html and corresponding JS, but without having to totally reverse engineer this all, can you please just give me a few steps to gather the debugging that it looks like is clearly already written into this extension? TIA!

@CollinChaffin
Copy link
Contributor Author

@deanoemcke Quick update, I can confirm that rolling back to an older build (I grabbed beta.128-68 Commit-g4e4d20e) instantly solves this issue which is again critical and prevents TGS from so much as initializing due to the above terminating errors. Rolling back and restarting Chrome then generates the "TGS has been updated" and works and no matter what even today's commit refuses to initialize (same errors as above). Hopefully you can arm me with some info on how to generate enough debugging here to indicate the issue as it apparently does NOT have anything to do with the Chrome DEV build as I initially suspected since the rollback to beta.128-68 Commit-g4e4d20e works on every DEV build right up to the current 72.0.3626.14.

@CollinChaffin
Copy link
Contributor Author

Here is the error generated now with latest commit on Chrome DEV. TGS now fails to perform ANY suspend actions simply throwing this error under inspect when I click to suspend a tab:

Uncaught (in promise) TypeError: Cannot read property 'queueTabAsPromise' of undefined
    at queueTabForSuspensionAsPromise (gsTabSuspendManager.js:49)
    at Object.queueTabForSuspension (gsTabSuspendManager.js:35)
    at activeTab (background.js:427)
    at background.js:176

@CollinChaffin
Copy link
Contributor Author

PR #827 created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants