Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): fix focus ordering within sidebar viewport #3317

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Oct 28, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Current focus order is: sidebar, nav, content

Fixes: #3314

What is the new behavior?

if side is left, focus order is nav, sidebar, content
if side is right, focus order is nav, content, sidebar

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Oct 28, 2024
@xelaint xelaint requested a review from a team as a code owner October 28, 2024 18:22
@xelaint xelaint merged commit 1af2e67 into develop Oct 28, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect focus order on sidebar viewport
1 participant