Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(design): convert toast component to standalone #3132

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat(design): convert toast component to standalone #3132

merged 1 commit into from
Oct 11, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Sep 27, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3027

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Sep 27, 2024
@xelaint xelaint requested review from a team as code owners September 27, 2024 16:15
damienwebdev
damienwebdev approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 8ccd628 into develop Oct 11, 2024
13 checks passed
@damienwebdev damienwebdev deleted the toast-standalone branch October 11, 2024 13:19
@gray-bot gray-bot mentioned this pull request Oct 11, 2024
Merged
gracetxgao pushed a commit to gracetxgao/daffodil that referenced this pull request Oct 24, 2024
@xelaint @gracetxgao
feat(design): convert toast component to standalone (graycoreio#3132)
d220885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienwebdev damienwebdev damienwebdev approved these changes

Assignees
No one assigned
Labels
package: design @daffodil/design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Update all @daffodil/design components as standalone
2 participants
@xelaint @damienwebdev