Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): add active router styles to nav header items #3127

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Sep 26, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3122

What is the new behavior?

Add routerLinkActive styles to daffio-header items. Excluded exact match so that the header item will remain active if user visits child pages of docs.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
xelaint Elain T.
@xelaint xelaint added the package: daff.io @daffodil/daff.io label Sep 26, 2024
@xelaint xelaint requested review from a team as code owners September 26, 2024 18:50
@xelaint xelaint requested a review from griest024 September 26, 2024 18:51

Verified

This commit was signed with the committer’s verified signature. The key has expired.
xelaint Elain T.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
xelaint Elain T.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
xelaint Elain T.
@xelaint xelaint merged commit c03a737 into develop Sep 27, 2024
8 checks passed
@gray-bot gray-bot mentioned this pull request Sep 26, 2024
@damienwebdev damienwebdev deleted the nav-item-active-style branch October 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Active Router Styles on Nav Header Items
1 participant