Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: remove color property from DaffPaginatorComponent #2873

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

color property is deprecated and should not remain in the codebase.

Part of: #2853

What is the new behavior?

There are no more deprecated properties in DaffPaginatorComponent

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE: color been removed from the codebase. Paginators are no longer themable.

Other information

@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change labels Jun 14, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jun 14, 2024
@xelaint xelaint requested a review from a team as a code owner June 14, 2024 17:52
@xelaint xelaint merged commit 5c91c6e into develop Jun 14, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Jun 14, 2024
@damienwebdev damienwebdev deleted the paginator-deprecation-remove branch October 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant