Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): make operation entity adapter extensible #2795

Conversation

griest024
Copy link
Member

@griest024 griest024 commented May 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

Makes the entity adapter a class for easier extensibility

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

also don't overwrite incoming `DaffState`
@griest024 griest024 added package: core @daffodil/core layer: state This PR or issue is related to the redux state layer status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels May 14, 2024
@griest024 griest024 self-assigned this May 14, 2024
@griest024 griest024 requested a review from a team as a code owner May 14, 2024 03:14
@griest024 griest024 merged commit 589a06c into graycoreio:develop May 14, 2024
50 checks passed
@gray-bot gray-bot mentioned this pull request May 14, 2024
@griest024 griest024 deleted the feat/core/state/extensible-entity-adapter branch May 14, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: state This PR or issue is related to the redux state layer package: core @daffodil/core status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant