Track handlers in subgraph_features table #4820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
commented
Aug 23, 2023
| @@ -47,6 +49,20 @@ impl blockchain::DataSource<Chain> for DataSource { | |||
| self.source.start_block | |||
| } | |||
|
|
|||
| fn handler_kinds(&self) -> HashSet<&str> { | |||
| let mut kinds = HashSet::new(); | |||
There was a problem hiding this comment.
Wondering if this should be a HashSet or just a Vec. But in ethereum we have blockHandlers with filters so its needed to iterate over it and add it to a HashSet to avoid duplication.
At the end way up in the call path, we convert this to a HashSet anyway.
incrypto32
commented
Aug 23, 2023
| @@ -80,6 +80,11 @@ impl blockchain::DataSource<Chain> for DataSource { | |||
| None | |||
| } | |||
|
|
|||
| fn handler_kinds(&self) -> HashSet<&str> { | |||
| // This is placeholder, substreams do not have a handler kind. | |||
| vec![SUBSTREAMS_HANDLER_KIND].into_iter().collect() | |||
There was a problem hiding this comment.
This was added as a placeholder to prevent having using an Option
incrypto32
commented
Aug 23, 2023
| @@ -0,0 +1,6 @@ | |||
| truncate table subgraphs.subgraph_features; | |||
There was a problem hiding this comment.
truncating the table so that the new columns values will get populated, subgraph_features table is populated during build_subgraph_runner so it will repopulate all the entries on startup
lutter
reviewed
Aug 28, 2023
incrypto32
force-pushed
the
incrypto32/add-handlers-to-subgraph-features
branch
from
3fb6c64 to
a90c656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4772