Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new table to track subgraph features #4679

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

incrypto32
Copy link
Member

Closes #4542

@incrypto32 incrypto32 marked this pull request as ready for review June 7, 2023 15:24
@incrypto32 incrypto32 requested a review from leoyvens June 7, 2023 15:24
f::features.eq(features),
f::data_sources.eq(data_source_kinds),
))
.on_conflict_do_nothing()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets overwrite on conflict:

    .on_conflict(f::id)
    .do_update()

store/postgres/src/primary.rs Show resolved Hide resolved
@incrypto32 incrypto32 force-pushed the incrypto32/subgraph-features branch from 0dbb2ec to 5c889d5 Compare June 8, 2023 11:25
@incrypto32 incrypto32 requested a review from leoyvens June 8, 2023 13:18
@incrypto32
Copy link
Member Author

@leoyvens Ah forgot, one more thing, will add tests and request a re-review.

@incrypto32 incrypto32 force-pushed the incrypto32/subgraph-features branch from d51b371 to ba8b479 Compare June 9, 2023 09:39
Copy link
Collaborator

@leoyvens leoyvens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the test! Just a couple comments.

runtime/wasm/src/module/mod.rs Outdated Show resolved Hide resolved
store/postgres/src/primary.rs Outdated Show resolved Hide resolved
@incrypto32 incrypto32 force-pushed the incrypto32/subgraph-features branch from ba8b479 to 8aac39d Compare June 9, 2023 14:10
@incrypto32 incrypto32 force-pushed the incrypto32/subgraph-features branch 2 times, most recently from 2e005d1 to 2399190 Compare June 12, 2023 06:42
@incrypto32 incrypto32 force-pushed the incrypto32/subgraph-features branch from 2399190 to 9ad0974 Compare June 12, 2023 06:46
@incrypto32 incrypto32 requested a review from leoyvens June 12, 2023 07:24
@incrypto32 incrypto32 merged commit 39094b1 into master Jun 12, 2023
@incrypto32 incrypto32 deleted the incrypto32/subgraph-features branch June 19, 2023 15:20
@incrypto32 incrypto32 self-assigned this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track deployment features & data source types
2 participants