-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new table to track subgraph features #4679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate it and wire it on deployment
leoyvens
reviewed
Jun 7, 2023
store/postgres/src/primary.rs
Outdated
f::features.eq(features), | ||
f::data_sources.eq(data_source_kinds), | ||
)) | ||
.on_conflict_do_nothing() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets overwrite on conflict:
.on_conflict(f::id)
.do_update()
incrypto32
force-pushed
the
incrypto32/subgraph-features
branch
from
June 8, 2023 11:25
0dbb2ec
to
5c889d5
Compare
@leoyvens Ah forgot, one more thing, will add tests and request a re-review. |
incrypto32
force-pushed
the
incrypto32/subgraph-features
branch
from
June 9, 2023 09:39
d51b371
to
ba8b479
Compare
leoyvens
requested changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the test! Just a couple comments.
incrypto32
force-pushed
the
incrypto32/subgraph-features
branch
from
June 9, 2023 14:10
ba8b479
to
8aac39d
Compare
incrypto32
force-pushed
the
incrypto32/subgraph-features
branch
2 times, most recently
from
June 12, 2023 06:42
2e005d1
to
2399190
Compare
incrypto32
force-pushed
the
incrypto32/subgraph-features
branch
from
June 12, 2023 06:46
2399190
to
9ad0974
Compare
leoyvens
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4542