Detect timeouts in asc_type_id #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They would previously be unconditionally treated as deterministic.
…ostExportError This all falls out of changing the signature of `fn asc_type_id`.
leoyvens
force-pushed
the
leo/issue-3576
branch
from
e805942 to
e2365b4
Compare
mangas
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3576.
When a timeout happened when calling
asc_type_idthis was incorrectly classified as a deterministic error. And these timeouts where happening frequently in the wild. Fixing this required correctly classifying wasm traps returned byasc_type_id. The second commit is the actual fix, most of the diff is from all the signatures that needed to change.