Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphman: new command to hastly delete a subgraph #4035

Merged
merged 15 commits into from
Oct 10, 2022
Merged

graphman: new command to hastly delete a subgraph #4035

merged 15 commits into from
Oct 10, 2022

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Oct 6, 2022 •
edited
Loading

Introduces a new graphman command to promptly delete all data from a deployment, even if it is running.

TODO:

  • Decide the name and placement for this command
  • Documentation

@tilacog tilacog force-pushed the tiago/graphman-delete-subgraph branch from a7d91cd to 730c2b8 Compare October 6, 2022 00:19
@tilacog tilacog requested a review from lutter October 6, 2022 00:21
lutter
lutter approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@lutter lutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I really like the user interaction. Just address the few comments I left, and then this is good to go.

As for the command name: after looking at the commands, I agree it's much better to make this a new command than to add it to graphman remove.

node/src/bin/manager.rs Outdated Show resolved Hide resolved
node/src/bin/manager.rs Outdated Show resolved Hide resolved
node/src/manager/commands/drop.rs Outdated Show resolved Hide resolved
node/src/manager/commands/info.rs Outdated Show resolved Hide resolved
@tilacog tilacog self-assigned this Oct 10, 2022
@tilacog tilacog added enhancement New feature or request area/graphman labels Oct 10, 2022
@tilacog tilacog merged commit 1a71dd7 into master Oct 10, 2022
@neysofu neysofu deleted the tiago/graphman-delete-subgraph branch November 23, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lutter lutter lutter approved these changes

Assignees

@tilacog tilacog

Labels
area/graphman enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilacog @lutter