Fix cross shard graft #4030
Merged
Fix cross shard graft #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoyvens
force-pushed
the
leo/fix-cross-shard-graft
branch
from
5994e64 to
9ce7f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit reverts most of 0c4417e, which was misguided since the graft code is already only called if the graft is pending.
Second commit fixes cross shard grafting, by not assuming that
load_deploymentwill succeed on the sameDeploymentStoreas the one in which the source subgraph is deployed.Read with whitespace diff disabled.