Fix provider selection when limit is set #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutter
force-pushed
the
lutter/prov
branch
3 times, most recently
from
af5f0f1 to
75f3de1
Compare
|
We'll merge this in next week after file data sources table has had a chance to bake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider selection with a limit did not work as intended because the node name was not passed around correctly, so that rules to set the limit were always evaluated for the node
default(commit 209786c fixes that)To make configuring limits easier and provide more insight into provider selection, this PR also adds a command
graphman config providerthat makes it possible to see which providers are eligible. Use it asgraphman --node-id index_node_0 --config /some/where/graph-node.toml config provider mainnet