Add exponential backoff retry for non deterministic errors #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoyvens
requested changes
Nov 22, 2021
evaporei
force-pushed
the
otavio/retry-non-deterministic-errors
branch
2 times, most recently
from
1b0937b to
c2de449
Compare
evaporei
commented
Nov 22, 2021
evaporei
force-pushed
the
otavio/retry-non-deterministic-errors
branch
2 times, most recently
from
30420ed to
910f7bd
Compare
evaporei
force-pushed
the
otavio/retry-non-deterministic-errors
branch
2 times, most recently
from
c2ce45a to
34a77b7
Compare
leoyvens
requested changes
Dec 3, 2021
evaporei
force-pushed
the
otavio/retry-non-deterministic-errors
branch
from
34a77b7 to
c0e4879
Compare
leoyvens
approved these changes
Dec 7, 2021
evaporei
added a commit
that referenced
this pull request
Mar 3, 2022
* deployment: Have just one is_failed function for SubgraphHealth * writable_store: Add method to get health of deployment * instance_manager: Use subgraph health to decide unfailure * instance_manager: Add exponential backoff retry for non-deterministic errors * store: Make health function async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After extensive testing, I think this is finally correct 🙌
This PR adds an exponential backoff to keep retrying non-deterministic errors until they get solved and the subgraph unfails.
Main changes:
ExponentialBackoffstructure to keep retrying non-deterministic errorsSolves #2945