Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update graphql playground url match pattern #5134

Closed
1 of 2 tasks
cmwhited opened this issue Jan 11, 2024 · 0 comments · Fixed by #5136
Closed
1 of 2 tasks

[Feature] Update graphql playground url match pattern #5134

cmwhited opened this issue Jan 11, 2024 · 0 comments · Fixed by #5136
Assignees
Labels
enhancement New feature or request

Comments

@cmwhited
Copy link

Description

The naming convention for latest and version deployment sent from studio to graph-node is changing.
Current structure:

  • latest: studio/s{studio db subgraph id}_latest
  • version: studio/v{studio db version id}
    Updated structure:
  • latest: u{studio db user id}/s{studio db subgraph id}/latest
  • version: u{studio db user id}/s{studio db subgraph id}/v{studio db version id}

In the studio query proxy package, we route received graphql requests (both queries and to load the graphql playground) to graph-node based off this naming convention.
For example, https://api.studio.staging.thegraph.com/proxy/28/testgnosis_1/v0.0.1/graphql would currently route to {GRAPH_NODE_BASE_URL}/subgraphs/name/studio/v{studio db version id}/graphql. But with this change, we will be routing to: {GRAPH_NODE_BASE_URL}/subgraphs/name/u{studio db user id}/s{studio db subgraph id}/v{studio db version id}/graphql (ex: {GRAPH_NODE_BASE_URL}/subgraphs/name/u89/s1478/v712/graphql).

Notes

After speaking with @lutter, he mentioned these are the places that need changed:

Also, currently the graphql POST requests are working with the updated structure, it is only the graphql playground endpoint that is returning

"message": "not found"

It is probably prudent to be able to handle both situations while the update is being performed.

Are you aware of any blockers that must be resolved before implementing this feature? If so, which? Link to any relevant GitHub issues.

No response

Some information to help us out

  • Tick this box if you plan on implementing this feature yourself.
  • I have searched the issue tracker to make sure this issue is not a duplicate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants