Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on recent 0.4dev #18

Open
sglyon opened this issue May 14, 2015 · 3 comments
Open

Tests fail on recent 0.4dev #18

sglyon opened this issue May 14, 2015 · 3 comments
Labels

Comments

@sglyon
Copy link
Collaborator

sglyon commented May 14, 2015

The tests are failing for me on recent (5-13-15) 0.4dev.

I have traced the problem down to the call to pinv on this line. For the exact same input matrix, pinv gives very different answers on 0.4dev than 0.3.8.

I have opened JuliaLang/LinearAlgebra.jl#214 in the main Julia repository. Maybe whoever made the changes to pinv over there will know what is going on.

@sglyon
Copy link
Collaborator Author

sglyon commented May 14, 2015

So that issue over there was closed and a reference to JuliaLang/julia#8859 was given.

It seems that they intentionally changed the behavior of pinv when moving from 0.3.8 to 0.4 to make routines using pinv more stable.

It's too bad that we get very different answers for the J_stat based on the version of Julia. That makes it quite difficult to test that function. This brings me back to JuliaLang/julia#17 though... where are the hard-coded stats and p-values coming from?

Any ideas for how to resolve testing issues on the different Julia versions?

@gragusa
Copy link
Owner

gragusa commented May 18, 2015

I think we could do like python and create a pinv2 that keeps doing the same things across version. But this would only solve the consistency issue. The question i have about this is: which of the two approaches (the pinv of 0.3.8 or the pinv of 0.4) works better?

If the latest pinv is better we could write version dependent test.....

@sglyon
Copy link
Collaborator Author

sglyon commented May 18, 2015

See the comments on the Julia issue I opened. There isn't a general answer for "which pinv is better", rather they said it goes case by case.

I didn't do enough digging to determine which one we want

@sglyon sglyon added the testing label May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants