Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graft-wallet-cli: show_transfers command should display public id for stake txes #377

Open
Dju01 opened this issue Jun 12, 2019 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@Dju01
Copy link
Contributor

Dju01 commented Jun 12, 2019

Proposed delivery date: 2019/07/20
Submit Proposal By:
GRFT reward: 100,000
Task scope: wallet, cli

Brief description:

Graft-wallet-cli command show_transfers should

  • indicate stake transactions (in "direction" field, see below)
  • display supernode public id as extra field in fields list
  345862    out(stake)       2019-06-04 14:32:52     50001.0000000000 ec187cfff349f1ec9643b4e9bd39902e4c6cf710068493bc9d05af5227e1c216 0000000000000000   0.0116199500 F4vPaFH4Q17NEEHE4KzkHRDSed97zqsiB5WrNJJf2hvNWW7AAMLaJA82k7xXE1oNhcWwZPWxz8fvUFWrQ83X9cpuFkfnDCG: 50001.0000000000 0 - b749ef0a580f4d72e8b5d1f01915dc4414f8176782a3ae2d16542c2176be4965

(last field is the public id)

  • display Supernode public id for Stake transactions in output of the 'show_transfer" command
Pending outgoing transaction found 
txid: <479a2....> 
Timestamp: 2019-06-13 14:39:00 
Amount: 50000.0000000000 
SN Public ID: 4014fc... 
Payment ID: d081d... 
Change: 1.0508136600 
Fee: 0.0116863400 
Note:

Acceptance test:

N Step Expected Result
1. Run curl --request GET http://localhost:28690/dapi/v2.0/cryptonode/getwalletaddress (supposing supernode configured and running on this address) {"testnet":true, "wallet_public_address":"F7a56E...", "id_key":"4014fcf...", "signature":"45f78..."}
2. Open graft-wallet-cli
3. Run wallet function : payment_id Receive Result: Random payment ID: <baf2633...>
4. Make tx: stake_transfer <wallet address> <amount> <lock_block_count> <Supernode_public_ID_key> <SuperNode Signature> <payment_ID> transfer F7a56E... 50000 60 4014fcf... 45f78... baf2633...
5. Send Tx and wait response Transaction successfully submitted, transaction <ded130...> You can check its status by using the show_transfers command. Height 348065, txid <ded130...>, 90.4643940500, idx 0/0
6. Run wallet command: show_transfer <TxId> Pending outgoing transaction found txid: <479a2....> Timestamp: 2019-06-13 14:39:00 Amount: 50000.0000000000 SN Public ID:4014fc... Payment ID: d081d... Change: 1.0508136600 Fee: 0.0116863400 Note:
7. Run wallet command: show_transfers out You should see the entry with your transaction, out(stake) in direction field and SN Public ID in the last field
8. Open a destination wallet, run wallet command: show_transfers in You should see the entry with your transaction, in(stake) in direction field and SN Public ID in the last field

Community Tasks Guidelines

@Dju01 Dju01 added the help wanted Extra attention is needed label Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant