Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA configuration for Gradio #6734

Open
1 task done
sumitsahoo opened this issue Dec 10, 2023 · 4 comments · May be fixed by #10187
Open
1 task done

PWA configuration for Gradio #6734

sumitsahoo opened this issue Dec 10, 2023 · 4 comments · May be fixed by #10187
Assignees
@pngwn
Labels
brainstorming Brainstorming issue enhancement New feature or request python Backend-related issue (Python) svelte Frontend-related issue (JS)
Milestone
Gradio 5.x

Comments

@sumitsahoo
Copy link

sumitsahoo commented Dec 10, 2023 •
edited
Loading

  • I have searched to see if a similar issue already exists.
    Yes

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Since Gradio is a web-based solution a PWA config should add more value. I see Gradio already supporting somewhat responsive designs and if PWA is enabled it will work like an app and can be installed on desktop and phone. All that is needed is a proper manifest (with proper icons) and a service worker. Maybe an option can be added to Gradio launch method which takes make_pwa as a boolean and sets the app icon just like we set favicon_path with the variable pwa_icon. Icons could be made more generic which takes a high res icons and generates favicon and pwa app icons and updates manifest json.

Additional context
N/A
@pngwn pngwn added enhancement New feature or request svelte Frontend-related issue (JS) python Backend-related issue (Python) brainstorming Brainstorming issue labels Dec 11, 2023
@abidlabs
Copy link
Member

This is actually a pretty cool idea, as it would allow people to save popular apps to their phones as apps. Seems like it would be pretty straightforward: https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Guides/Making_PWAs_installable

@sumitsahoo
Copy link
Author

@abidlabs Yep and the thing is Gradio is already responsive (pretty much). There are helper tools that suggest what is needed for making an existing page a PWA. See PWA Builder. Hope this feature request can be added to the roadmap.

@caviri
Copy link

caviri commented Apr 30, 2024

I think this would be a great feature to have on gradio.

@abidlabs abidlabs added this to the Gradio 5️⃣ milestone Jul 3, 2024
@abidlabs abidlabs modified the milestones: Gradio 5, Gradio 5.x Sep 12, 2024
@sumitsahoo
Copy link
Author

So is it really planned for v5? So existing if it is.

@whitphx whitphx linked a pull request Dec 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pngwn pngwn

Labels
brainstorming Brainstorming issue enhancement New feature or request python Backend-related issue (Python) svelte Frontend-related issue (JS)
Projects
None yet
Milestone
Gradio 5.x
Development

Successfully merging a pull request may close this issue.

manifest json for PWA gradio-app/gradio
4 participants
@abidlabs @sumitsahoo @pngwn @caviri