Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more parameters support #3651

Closed
KonoromiHimaries opened this issue Mar 29, 2018 · 1 comment
Closed

add more parameters support #3651

KonoromiHimaries opened this issue Mar 29, 2018 · 1 comment
Labels

Comments

@KonoromiHimaries
Copy link

KonoromiHimaries commented Mar 29, 2018

AdguardTeam/AdguardBrowserExtension#917

examples suggested parameters

!#if load_this_rule_if_you_have_a_enabled_list(filterlist:"EasyList_Privacy,EasyList")
example.rule#example

!#if not_load_this_rule_if_you_have_a_enabled_list(filterlist:"Fanboys_Enhanced_Tracking_List")
example.rule#example
!#if load_this_rule_if_your_language_is(lang:"Polish,English")
example.rule#example
!#if load_this_rule_if_zoom_is(zoom:"125%-150%")
example.rule#example
!#if load_this_rule_if_screen_resolution_is(resolution:"720p-1080p")
example.rule#example
!#if load_this_rule_if_it_does_not_detect_element(rule:"###download")
example.rule#example

example custom parameter - profiling

!#if index_this_rule_at_the_parameters(parameter:"example, profile-popup, filterlist-fanboy, priority-2, release")
example.rule#example
!#if load_this_rule_if_your_custom-global-parameters_is(parameter:"example, profile-popup, filterlist-fanboy, priority-2, release")
example.rule#example
!#set-global-parameter profile-popup(only-for-filterlist:"EasyList_Privacy,EasyList")

then i will be able to can set my custom profile of this filter list
https://github.com/KonoromiHimaries/polish-ads-filter/blob/4a7ab7773eb599ab72dada018fda00dca155c43e/internal-filters/adblock_wewnetrzne.txt#L515

it will be a great addition for it
#3638

@gorhill
Copy link
Owner

gorhill commented Apr 16, 2018

Declining because there is no actual, specific and convincing cases provided to justify supporting all these directives for the benefit of all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants