-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce @ObsoleteApi #1887
Conversation
api-common-java/src/main/java/com/google/api/core/ObsoleteApi.java
Outdated
Show resolved
Hide resolved
api-common-java/src/main/java/com/google/api/core/ObsoleteApi.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Mike Eltsufin <[email protected]>
…java Co-authored-by: Mike Eltsufin <[email protected]>
Maybe we can add a blurb here: https://github.com/googleapis/sdk-platform-java/blob/main/gax-java/README.md#versioning about this new annotation (I believe this annotation is going to be used in Gax?). |
Great idea! Added, PTAL. |
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'll start adding this to the threeten PR #1872
This PR introduces
@ObsoleteApi
. Deprecating any client side feature including adding@Deprecated
annotation is considered a breaking change based on the new support policy, hence we need an alternative way to signal us and customers that an API is deprecating. This annotation is not a direct replacement of@Deprecated
, it's more like a pre-deprecation annotation, it has two major purposes:@ObsoleteApi
methods to@Deprecated
before a major version release, and eventually remove it in another major version release.@Deprecated
since IDE would strike through deprecated methods, but customers can see it easily through Javadocs while hovering over on it.