Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(owlbot): owlbot:run label does not trigger owlbot; owlbot:run label is not removed #5295

Closed
parthea opened this issue Feb 24, 2024 · 5 comments · Fixed by #5297
Closed

bug(owlbot): owlbot:run label does not trigger owlbot; owlbot:run label is not removed #5295

parthea opened this issue Feb 24, 2024 · 5 comments · Fixed by #5297
Assignees
@chingor13
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Feb 24, 2024 •
edited
Loading

In googleapis/python-ndb#949 and googleapis/python-datastore#525, I've added the owlbot:run label but it is not triggering owlbot to run.

It also appears to be stuck in other repositories. The first 19 pages of the results show PRs which still have the owlbot:run label which were opened in the last 24 hours.

https://github.com/search?q=org%3Agoogleapis+is%3Apr+is%3Aunmerged++is%3Aopen+label%3A%22owlbot%3Arun%22&type=pullrequests&s=created&o=desc&p=19
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Feb 24, 2024
@arpan14
Copy link

arpan14 commented Feb 26, 2024

Facing the same issue for Spanner PR - googleapis/java-spanner#2927

@shivgautam
Copy link

Same for google-cloud-ruby as well. Example PR: googleapis/google-cloud-ruby#24939

@chingor13
Copy link
Contributor

From the logs, I am seeing a lot of fetch failed errors during the removal of the label:

HttpError: fetch failed
    at /usr/src/app/node_modules/@octokit/request/dist-node/index.js:110:11
    at async sendRequestWithRetries (/usr/src/app/node_modules/@octokit/auth-app/dist-node/index.js:376:12)
    at async removeOwlBotLabel (/usr/src/app/build/src/owl-bot.js:324:9)
    at async Object.handlePullRequestLabeled (/usr/src/app/build/src/owl-bot.js:290:9)
    at async /usr/src/app/build/src/owl-bot.js:106:9
    at async Promise.all (index 0)
    at async /usr/src/app/node_modules/gcf-utils/build/src/gcf-utils.js:404:25

@chingor13
Copy link
Contributor

chingor13 commented Feb 26, 2024 •
edited
Loading

Perhaps we're running into octokit/core.js#511 (comment). It is a delete request, but this code hasn't been touched or deployed in a while.

Edit: the node version was updated in #5293 3 days, roughly around when this started happening

@chingor13
Copy link
Contributor

After migrating traffic back to the previous owlbot revision, it can remove the label and proceed again. Looking into options for fixing this.

This was referenced Feb 26, 2024
Closed
Merged
chingor13 added a commit that referenced this issue Feb 26, 2024
@chingor13
feat: require node 18 for owl-bot (#5297)
8548c6f 
Fixes #5295 

deps: update `@octokit/endpoint` to v7
build: test owl-bot against node 18
ci: use `no-experimental-fetch` for nock/node18 compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: require node 18 for owl-bot googleapis/repo-automation-bots
4 participants
@chingor13 @parthea @arpan14 @shivgautam