Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect signoff in config #2247

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

shanduur
Copy link
Contributor

@shanduur shanduur commented Mar 16, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2246 🦕

@shanduur shanduur requested review from a team as code owners March 16, 2024 20:37
Copy link

google-cla bot commented Mar 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 16, 2024
@shanduur shanduur force-pushed the fix/signoff-config branch 3 times, most recently from eae303b to f7661f0 Compare March 16, 2024 21:02
Signed-off-by: Mateusz Urbanek <[email protected]>
@shanduur shanduur force-pushed the fix/signoff-config branch from f7661f0 to 1c817bf Compare March 16, 2024 21:03
@chingor13 chingor13 merged commit d7d3958 into googleapis:main Mar 29, 2024
11 checks passed
@shanduur shanduur deleted the fix/signoff-config branch April 14, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to signoff commits from config
2 participants