fix(helm): maintain any existing comments in Chart.yaml #1968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in #1944, the current approach for Helm charts (using
js-yaml
library) strips all comments from the file. This PR switches to using the popularyaml
library (eemeli/yaml), and then patching the version value directly. This helps maintain any comments which have been added to the Chart.yaml - Renovate comments are the driving cause in our case.Fixes #1944 🦕