Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xml): preserve trailing newline if the xml file had one #1911

Merged
merged 2 commits into from
Apr 10, 2023
Merged

fix(xml): preserve trailing newline if the xml file had one #1911

merged 2 commits into from
Apr 10, 2023

Conversation

chingor13
Copy link
Contributor

Fixes #1894

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 10, 2023
@chingor13 chingor13 changed the title test: failing test for preserving newlines fix(xml): preserve trailing newline if the xml file had one Apr 10, 2023
@chingor13 chingor13 marked this pull request as ready for review April 10, 2023 21:02
@chingor13 chingor13 requested review from a team as code owners April 10, 2023 21:02
@chingor13 chingor13 merged commit b899da6 into main Apr 10, 2023
@chingor13 chingor13 deleted the xml-preserve-newline branch April 10, 2023 22:18
@release-please release-please bot mentioned this pull request Apr 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maven pom.xml EOF newline getting removed
2 participants
@chingor13 @sofisl