Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateBucketRequest type is misaligned with JSON API #2454

Closed
ddelgrosso1 opened this issue May 3, 2024 · 0 comments · Fixed by #2489
Closed

CreateBucketRequest type is misaligned with JSON API #2454

ddelgrosso1 opened this issue May 3, 2024 · 0 comments · Fixed by #2489
Assignees
@ddelgrosso1
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ddelgrosso1
Copy link
Contributor

Currently the CreateBucketRequest type is missing some fields that are supported by the JSON API .

Short term: add the missing fields
Long term: Use a single metadata / resource representation type
@ddelgrosso1 ddelgrosso1 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 3, 2024
@ddelgrosso1 ddelgrosso1 self-assigned this May 3, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 3, 2024
@ddelgrosso1 ddelgrosso1 mentioned this issue Jun 14, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make CreateBucketRequest extend from BucketMetadata to allow all… ddelgrosso1/nodejs-storage
1 participant
@ddelgrosso1