Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support autoclass v2.1 #2325

Merged
merged 3 commits into from
Oct 30, 2023
Merged

feat: support autoclass v2.1 #2325

merged 3 commits into from
Oct 30, 2023

Conversation

ddelgrosso1
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 commented Oct 11, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2306 🦕

@ddelgrosso1 ddelgrosso1 requested a review from cojenco October 11, 2023 14:20
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Oct 11, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 11, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 11, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 11, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 11, 2023
@ddelgrosso1 ddelgrosso1 marked this pull request as ready for review October 11, 2023 15:18
@ddelgrosso1 ddelgrosso1 requested review from a team as code owners October 11, 2023 15:18
@ddelgrosso1 ddelgrosso1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 11, 2023
@ddelgrosso1
Copy link
Contributor Author

Marking do not merge until @cojenco gives the go ahead.

cojenco
cojenco approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this. We plan to release this feature in the week of 11/03

samples/getAutoclass.js Outdated Show resolved Hide resolved
cojenco
cojenco reviewed Oct 16, 2023
View reviewed changes
samples/setAutoclass.js Outdated Show resolved Hide resolved
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 17, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2023
@cojenco
Copy link
Contributor

cojenco commented Oct 30, 2023

This is ready for merge and release now, thanks @ddelgrosso1

@ddelgrosso1 ddelgrosso1 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 30, 2023
@ddelgrosso1 ddelgrosso1 merged commit 6572ce9 into googleapis:main Oct 30, 2023
15 checks passed
@ddelgrosso1 ddelgrosso1 deleted the autoclass branch October 30, 2023 16:48
@release-please release-please bot mentioned this pull request Oct 30, 2023
Merged
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Autoclass v2.1
3 participants
@ddelgrosso1 @cojenco @danielbankhead