Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Make node 14 the minimum supported version #2244

Merged
merged 13 commits into from
Aug 3, 2023
Merged

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners July 24, 2023 14:28
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node12/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/conformance-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@google-cla
Copy link

google-cla bot commented Jul 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: storage Issues related to the googleapis/nodejs-storage API. labels Jul 24, 2023
d-goog and others added 9 commits July 24, 2023 14:32
* refactor: Remove `extend`

This is the prelimary, `src`-only commit.

* fix: object merging

* chore: remove log

* chore: minor clean-up

* chore: more clean-up

* refactor: remove `extend`

* perf!: treat provided options as mutable
* fix!: Remove extraneous validation in favor of server errors

* remove test
…ted (#2214)

* refactor!: mark bucket.setLabels and associated interfaces as deprecated

* update addBucketLabel to use setMetadata

* mark getLabels / deleteLabels deprecated, update samples
* test: cleanup kms tests to avoid setting incorrect keys (#2213)

* chore(deps): update dependency c8 to v8 (#2221)

* feat!: better typing for metadata

* more metadata typing

* fix merge problems

* remove extend

* fix merge conflicts

---------

Co-authored-by: Mend Renovate <[email protected]>
* chore!: make node 14 the minimum version

* move conformance test to node 14

* package upgrades, fix unit test compilation

* update google owned deps

* fix tests

* remove node 12 kokoro folders
@ddelgrosso1 ddelgrosso1 reopened this Jul 26, 2023
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2023
@ddelgrosso1
Copy link
Contributor Author

Not sure why renovate-bot is failing the CLA check 🤷‍♂️

@ddelgrosso1 ddelgrosso1 merged commit f48dcd2 into main Aug 3, 2023
@ddelgrosso1 ddelgrosso1 deleted the storage-seven branch August 3, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants