Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid links rendered from TSDoc #2219

Closed
kmishmael opened this issue Jun 11, 2023 · 1 comment
Closed

Invalid links rendered from TSDoc #2219

kmishmael opened this issue Jun 11, 2023 · 1 comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kmishmael
Copy link

kmishmael commented Jun 11, 2023

Hi
While going through the TSDoc Documentation in VSCode, I noticed that clicking on a link redirects me to a 404 page. Upon further investigation, I discovered that the way the links were written posed difficulties for VSCode to render them correctly, and it also did not adhere to the recommended format of TSDoc.

For instance, the following link:

/**
* See {@link https://cloud.google.com/storage/docs/json_api/v1/objects/list| Objects: list API Documentation}
*/ 

is rendered as:

https://cloud.google.com/storage/docs/json_api/v1/objects/listObjects:

instead of the desired:

https://cloud.google.com/storage/docs/json_api/v1/objects/list

To address this issue, it is recommended to follow the TSDoc format, which involves placing whitespace before and after the | symbol:

/**
* See {@link https://cloud.google.com/storage/docs/json_api/v1/objects/list | Objects: list API Documentation}
*/ 

By making this adjustment, the links will be rendered correctly within VSCode and conform to the recommended TSDoc format.

@kmishmael kmishmael added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 11, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jun 11, 2023
@ddelgrosso1
Copy link
Contributor

Hi @kmishmael thank you for opening an issue. We are currently planning to rework docs in TSDoc format. Please see issue #2111. Since this is a duplicate of that issue, I am going to close it. Please feel free to add any additional feedback to that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants