Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multiple lifecycle rules #2062

Merged
merged 5 commits into from
Sep 8, 2022
Merged

feat: add multiple lifecycle rules #2062

merged 5 commits into from
Sep 8, 2022

Conversation

shaffeeullah
Copy link
Contributor

Fixes #2060

@shaffeeullah shaffeeullah requested review from a team as code owners September 8, 2022 18:58
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/nodejs-storage API. labels Sep 8, 2022
danielbankhead
danielbankhead approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 optional suggestion

src/bucket.ts Outdated Show resolved Hide resolved
@shaffeeullah shaffeeullah merged commit fbe2deb into main Sep 8, 2022
@shaffeeullah shaffeeullah deleted the shaffeeullah/addMultipleLifecycleRules branch September 8, 2022 20:22
@release-please release-please bot mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addLifecycleRule cannot be called concurrently
2 participants
@shaffeeullah @danielbankhead