fix: correctly handle an empty file in download function #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
shaffeeullah
approved these changes
Jun 28, 2022
test/file.ts
Outdated
| @@ -55,6 +55,7 @@ import { | |||
| } from '../src/file'; | |||
| import {ExceptionMessages, IdempotencyStrategy} from '../src/storage'; | |||
| import {formatAsUTCISO} from '../src/util'; | |||
| import {timeStamp} from 'console'; | |||
There was a problem hiding this comment.
remove unused variable
There was a problem hiding this comment.
When tab autocomplete goes wrong...
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
danielbankhead
approved these changes
Jun 29, 2022
| writable.write(data); | ||
| fileStream.pipe(writable).on('error', callback).on('finish', callback); | ||
| }); | ||
| fileStream |
There was a problem hiding this comment.
[Optional]: Now we're on Node 12+ we can use for await (const chunk of readable) to make this tinier: https://nodejs.org/api/stream.html#readablesymbolasynciterator
There was a problem hiding this comment.
Since this isn't within an async function currently I'm going to leave it alone for the time being until we modernize our function signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1991 🦕