Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(deps): Remove stream-events dependency #1916

Closed
danielbankhead opened this issue May 6, 2022 · 0 comments · Fixed by #2022
Closed

refactor(deps): Remove stream-events dependency #1916

danielbankhead opened this issue May 6, 2022 · 0 comments · Fixed by #2022
Assignees
@ddelgrosso1
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Contributor

The usage of stream-events can be internalized using native streams and events - such as emitting writing on _write method (e.g. f666842#diff-eee587ca8a340f7ab2aed59173accad2fb1d776f2c176ebda172d1ea1e239f81R390-R396)
@danielbankhead danielbankhead added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels May 6, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 6, 2022
@danielbankhead danielbankhead mentioned this issue May 6, 2022
Closed
6 tasks
@shaffeeullah shaffeeullah mentioned this issue May 23, 2022
Closed
@ddelgrosso1 ddelgrosso1 mentioned this issue Aug 8, 2022
Merged
4 tasks
@danielbankhead danielbankhead mentioned this issue Aug 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(deps): remove stream-events dependency ddelgrosso1/nodejs-storage
2 participants
@danielbankhead @ddelgrosso1